Skip to content

PERF: Fix ASV CSV benchmarks #60689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rhshadrach merged 1 commit into from
Jan 9, 2025
Merged

PERF: Fix ASV CSV benchmarks #60689

rhshadrach merged 1 commit into from
Jan 9, 2025

Conversation

@rhshadrach
Copy link
Member

@rhshadrach rhshadrach commented Jan 9, 2025 •
edited
Loading

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

self.data is just calling .seek(0) on the StringIO object. The current implementation doesn't fail on our CI because we only run each benchmark once.

@rhshadrach rhshadrach added Performance Memory or execution speed performance IO CSV read_csv, to_csv labels Jan 9, 2025
@rhshadrach rhshadrach added this to the 3.0 milestone Jan 9, 2025
@rhshadrach
Copy link
Member Author

rhshadrach commented Jan 9, 2025

Merging as this is blocking some work I'm doing on ASVs.

@rhshadrach rhshadrach merged commit 0110487 into pandas-dev:main Jan 9, 2025
55 of 57 checks passed
@rhshadrach rhshadrach deleted the fix_asvs branch December 21, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

IO CSV read_csv, to_csv Performance Memory or execution speed performance

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

1 participant

@rhshadrach