make grouping column an agg #6997
Conversation
There was a problem hiding this comment.
why is all this necessary? _try_cast does this IIRC
There was a problem hiding this comment.
it looks like agg must upcast to float, i can't recall tbh... also my choice of api is not good.
I'm not even using it, so er... guess I should remove.
There was a problem hiding this comment.
ah yes, it upcast to float... this explains the "wip" commit message
There was a problem hiding this comment.
ok but try_cast should still be able to fix it maybe it needs more hints)
There was a problem hiding this comment.
I can take this - u can lot on plate!
There was a problem hiding this comment.
that would be amazing, thanks! This was also attempting to address #6594 btw, looks like ohlc in there twice.
|
closing in favor of #7000 |
3 participants
fixes #5610