Skip to content

VIS: register datetime64 in matplotlib units registry (GH8614) #8693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jorisvandenbossche merged 1 commit into from
Nov 5, 2014
Merged

VIS: register datetime64 in matplotlib units registry (GH8614) #8693

jorisvandenbossche merged 1 commit into from
Nov 5, 2014

Conversation

@jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Oct 31, 2014

Closes #8614

@jorisvandenbossche jorisvandenbossche added this to the 0.15.1 milestone Oct 31, 2014
@jorisvandenbossche
Copy link
Member Author

jorisvandenbossche commented Oct 31, 2014

@shoyer @jreback @agijsberts

agijsberts
agijsberts reviewed Oct 31, 2014
View reviewed changes
doc/source/whatsnew/v0.15.1.txt Outdated
Copy link
Contributor

@agijsberts agijsberts Oct 31, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

del matplotlib.units.registry[np.datetime64] would imho be slightly neater.

Copy link
Member Author

@jorisvandenbossche jorisvandenbossche Nov 5, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep indeed

@jreback
Copy link
Contributor

jreback commented Nov 5, 2014

@jorisvandenbossche ?

@jorisvandenbossche jorisvandenbossche force-pushed the plot-datetime64 branch 2 times, most recently from 0146152 to 932afd8 Compare November 5, 2014 10:01
@jorisvandenbossche
Copy link
Member Author

jorisvandenbossche commented Nov 5, 2014

Rebased, and will merge when travis is green

jorisvandenbossche added a commit that referenced this pull request Nov 5, 2014
@jorisvandenbossche
Merge pull request #8693 from jorisvandenbossche/plot-datetime64
9516c06 
VIS: register datetime64 in matplotlib units registry (GH8614)
@jorisvandenbossche jorisvandenbossche merged commit 9516c06 into pandas-dev:master Nov 5, 2014
tacaswell
tacaswell reviewed Nov 5, 2014
View reviewed changes
doc/source/whatsnew/v0.15.1.txt
Copy link
Contributor

@tacaswell tacaswell Nov 5, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you meant to merge the conflict markers.

Copy link
Member Author

@jorisvandenbossche jorisvandenbossche Nov 5, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, no not really ..
should have gone something wrong with rebasing

Copy link
Member Author

@jorisvandenbossche jorisvandenbossche Nov 5, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for noticing!

Copy link
Member Author

@jorisvandenbossche jorisvandenbossche Nov 5, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a0ac41d

@jorisvandenbossche jorisvandenbossche mentioned this pull request Nov 5, 2014
Closed
@pelson pelson mentioned this pull request Dec 3, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Visualization plotting

Projects

None yet

Milestone

0.15.1

Development

Successfully merging this pull request may close these issues.

Plotting of DatetimeIndex directly with matplotlib no longer gives datetime formatted axis (0.15)

4 participants

@jorisvandenbossche @jreback @tacaswell @agijsberts