-
-
Notifications
You must be signed in to change notification settings - Fork 19.4k
TST: harmonize testing namespace in TestCase (GH8023) #8923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pandas/util/testing.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can just pass the np_array and assert_equal arguments, as this will mask wrong arguments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorisvandenbossche ok will do, i thought this would be better because when 1 function changes then the other will have to be updated.
|
@papaloizouc Are you interested in trying to add the other |
|
@jorisvandenbossche sure will do |
|
I think we should try to do the adding of the methods a bit more automatically (so also the docstring are kept as the original). Eg something like |
|
sure easy enough to inspect the module namespace and auto add the methods to TestCase via a generated wrapper |
pandas/util/testing.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't even need to do this in a function, just put it at the end of the module and directly update TestCase. (pls put a comment before though explaining what this is doing).
335df10 to
12d75f3
Compare
TST: changed *args, **kwargs to fixed arguments. pandas-dev#8023 TST: Moved rest of the test functions to module level. pandas-dev#8023 TST: patch all module level assert functions to TestCase. pandas-dev#8023 CLN: Cleanup TestCase assert functions pathing pandas-dev#8023
12d75f3 to
844f7ae
Compare
|
Merged via ace3c46 |
|
@papaloizouc Thanks! |
closes #8023
Merged via ace3c46