Skip to content

bug in groupby when key space exceeds int64 bounds #9380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 1 commit into from
Jan 31, 2015
Merged

bug in groupby when key space exceeds int64 bounds #9380

jreback merged 1 commit into from
Jan 31, 2015

Conversation

@behzadnouri
Copy link
Contributor

@behzadnouri behzadnouri commented Jan 31, 2015

closes #9096

also improves performance when there is int64 overflow; complete groupby benchmarks here.

-------------------------------------------------------------------------------
Test name                                    | head[ms] | base[ms] |  ratio   |
-------------------------------------------------------------------------------
groupby_int64_overflow                       | 637.6967 | 3021.1190 |   0.2111 |
-------------------------------------------------------------------------------

Ratio < 1.0 means the target commit is faster then the baseline.
Seed used: 1234

Target [d6e3cb7] : bug in groupby when key space exceeds int64 bounds
Base   [391f46a] : BUG: allow for empty SparseSeries SparsePanel constructors (GH9272)

@jreback jreback added this to the 0.16.0 milestone Jan 31, 2015
@jreback
Copy link
Contributor

jreback commented Jan 31, 2015

@behzadnouri this looks gr8! thanks

jreback added a commit that referenced this pull request Jan 31, 2015
@jreback
Merge pull request #9380 from behzadnouri/i8grby
9f439f0 
bug in groupby when key space exceeds int64 bounds
@jreback jreback merged commit 9f439f0 into pandas-dev:master Jan 31, 2015
@jreback jreback mentioned this pull request Jan 31, 2015
Closed
@selasley selasley mentioned this pull request Feb 1, 2015
Merged
@behzadnouri behzadnouri deleted the i8grby branch February 7, 2015 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug Groupby

Projects

None yet

Milestone

0.16.0

Development

Successfully merging this pull request may close these issues.

Groupby "negative dimensions are not allowed" error and bad key behaviour when there are NaNs values.

2 participants

@behzadnouri @jreback