TST/DOC: Fix tests and docs for .cat raising AttributeError if invalid #9629
+19
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up on GH9617 Fixes GH8814 -- is it fair to say that ``hasattr(s, 'cat')`` is probably the best solution we're going to come up with for checking for categorical data?
shoyer
added
Build
Member
There was a problem hiding this comment.
can you add a :okexcept: option to the directive here (so the doc building does not issue a warning for the failure)?
Member
Author
There was a problem hiding this comment.
hasattr catches the error, so I don't think that's necessary?
Member
There was a problem hiding this comment.
ah, yes, sorry, I was looking too quickly, thought you were giving an example of that accessing the attribute raises, but it is hasattr, not getattr ..
Member
Author
|
FYI this commit passed on my fork so we can safely merge this: https://travis-ci.org/shoyer/pandas/builds/53882855 |
Contributor
|
ok, looks ok to me. go ahead and merge. |
shoyer
added a commit
that referenced
this pull request
Mar 11, 2015
TST/DOC: Fix tests and docs for .cat raising AttributeError if invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #9617
Fixes #8814 -- is it fair to say that
hasattr(s, 'cat')is probablythe best solution we're going to come up with for checking for categorical
data?
CC @jreback @jorisvandenbossche @JanSchulz