Fix: set FD_CLOEXEC flag to unix client fd #743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Are you opening this pull request for bug-fix, optimization or new feature?
This PR is for bug-fix.
Currently, the Unix client fd will leak to the child process, because we call
unix.Dup(int(fd))--which will remove theFD_CLOEXECflag--to duplicate the raw fd, and that is unsafe.2. Please describe how these code changes achieve your intention.
3. Please link to the relevant issues (if any).
4. What documentation changes (if any) need to be made/updated because of this PR?
4. Checklist