process_executor accepts action digests and buildbarn links#11283
Conversation
tdyas
left a comment
tdyas
left a comment
There was a problem hiding this comment.
This looks pretty nice!
Also FYI, I'm finishing up the Tonic/gRPC refactor this week. This PR does not look like it will cause much of a merge conflict. (Although I will need to port the BuildBarn proto generation to Prost.) Will tag you as a reviewer of the Tonic PR once I have it submitted in next day or so.
|
Also the |
|
Amazing, thanks for the review @tdyas! I'll definitely wait for your tonic stuff to land, I don't want to make that any harder for you than it already is! Will address all comments, and split off a separate |
|
Split off structopt changes in #11306 |
illicitonion
force-pushed
the
process-executor
branch
from
4f327d8 to
b031ca2
Compare
|
All addressed :) Still very happy to wait for your prost/tonic migration to land first, though! |
Tonic/Prost refactor is in #11307. |
illicitonion
force-pushed
the
process-executor
branch
from
b031ca2 to
1590e46
Compare
|
Congrats! Glad it got in! I've rebased this onto Tonic/Prost - do you want to take another look, or shall I just merge @tdyas? :) |
This allows you to take an action which ran (perhaps because you have metadata from the remote cluster) and reproduce it, locally or remotely. It also: * Allows specifying prefixes for commands, so you can run under `strace` or similar. * Allows specifying a CAS server without an execution server, so that you can fetch remote digests but perform execution locally. * Broadens `expand_local_digests` to `expand_digests` with a local-only mode, so that if you're fetching the digest from a remote CAS, you don't get errors complaining that things it references aren't available locally.
illicitonion
force-pushed
the
process-executor
branch
from
1590e46 to
4b6f4ac
Compare
3 participants
This allows you to take an action which ran (perhaps because you have metadata from the remote cluster) and reproduce it, locally or remotely. It also:
process_executorto usestructoptinstead ofclapdirectly, allowing for cleaner arg parsing.straceor similar.expand_local_digeststoexpand_digestswith a local-only mode, so that if you're fetching the digest from a remote CAS, you don't get errors complaining that things it references aren't available locally.I strongly recommend reviewing commits separately :)