avoid unnecessary copy in cache code path#11348
Merged
Merged
Conversation
[ci skip-build-wheels]
illicitonion
approved these changes
Dec 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ci skip-build-wheels]
Problem
#11344 introduced a
.to_bytes()helper for protobuf messages. However, in one spot, this introduced a unnecessary copy because the result is converted to aVec<u8>immediately.Solution
Remove the unnecessary copy by encoding into a
Vec<u8>directly.It might be possible to switch the
PlatformAndResponseBytesstruct to useBytesinstead ofVec<u8>but that would require reasoning about whether it would change the format of the struct when stored in the cache, which I want to avoid having to do for now.Result
Existing tests pass.