Workaround Rust 1.49 breaking macOS processes with a materialized argv0#11452
Merged
Eric-Arellano merged 3 commits intoJan 13, 2021
Merged
Conversation
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
commented
Jan 12, 2021
Contributor
Author
Eric-Arellano
left a comment
Eric-Arellano
left a comment
There was a problem hiding this comment.
Thank you @tdyas for figuring this out! I can now run ./pants test and ./pants count-loc on mac silicon!
This was referenced Jan 12, 2021
Eric-Arellano
added a commit
that referenced
this pull request
Jan 13, 2021
From the Remote Execution API: https://github.com/bazelbuild/remote-apis/blob/9e72daff42c941baaf43a4c370e2607a984c58a7/build/bazel/remote/execution/v2/remote_execution.proto#L472-L475 > The first argument must be the path to the executable, which must be either a relative path, in which case it is evaluated with respect to the input root, or an absolute path. These tests were causing #11452 to fail because the unconstrained `python` looked like a relative path even though it isn't. [ci skip-build-wheels] [ci skip-rust]
…-darwin [ci skip-build-wheels]
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
jsirois
approved these changes
Jan 13, 2021
gshuflin
approved these changes
Jan 13, 2021
Eric-Arellano
added a commit
that referenced
this pull request
Jan 13, 2021
This is necessary to compile the engine on Mac Silicon. We can now safely upgrade thanks to #11452 fixing the issue with macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works around #11406, which we found is due to rust-lang/rust#80819.
To workaround, we absolutify relative paths when they are argv[0]. We only do this for local execution.