Fix release script's expected maintainers#18477
Merged
Eric-Arellano merged 2 commits intopantsbuild:mainfrom Mar 12, 2023
Merged
Fix release script's expected maintainers#18477Eric-Arellano merged 2 commits intopantsbuild:mainfrom
Eric-Arellano merged 2 commits intopantsbuild:mainfrom
Conversation
Eric-Arellano
added
the
category:internal
Eric-Arellano
commented
Mar 12, 2023
Comment on lines
-197
to
-198
| Also, update the [Changelog](doc:changelog) page with the new release series at the top of the table. It's okay if there are no "highlights" yet. | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This won't work anymore because docs are from version control. Imo this shouldn't be part of the dev0 process. It should be part of the stable release process, along with the blog publishing
|
|
||
| See the `docs/NOTES.md` for instructions setting up the the necessary Node tooling your first time. | ||
| You'll need to 1st login as outlined there via some variant of `npx rdme login --project pants ...`. | ||
| You'll need to 1st login as outlined there via some variant of `npx rdme login --2fa --project pants ...`. |
Contributor
Author
There was a problem hiding this comment.
We want everyone to be using 2FA
benjyw
approved these changes
Mar 12, 2023
Merged
kaos
pushed a commit
to kaos/pants
that referenced
this pull request
Apr 24, 2023
The release process fails otherwise. Also improve the docs on how to approach documentation changes. [ci skip-rust] [ci skip-build-wheels]
kaos
pushed a commit
to kaos/pants
that referenced
this pull request
Apr 24, 2023
The release process fails otherwise. Also improve the docs on how to approach documentation changes.
kaos
added a commit
that referenced
this pull request
Apr 24, 2023
kaos
added a commit
that referenced
this pull request
Apr 24, 2023
benjyw
pushed a commit
to benjyw/pants
that referenced
this pull request
May 12, 2023
The release process fails otherwise. Also improve the docs on how to approach documentation changes.
benjyw
added a commit
that referenced
this pull request
May 13, 2023
stuhood
added a commit
that referenced
this pull request
May 14, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release process fails otherwise.
Also improve the docs on how to approach documentation changes.