Skip to content

initial draft of What's New for v2.17.x#19168

Merged
tdyas merged 2 commits intopantsbuild:mainfrom
tdyas:2.17.x_whats_new
Aug 9, 2023
Merged

initial draft of What's New for v2.17.x#19168
tdyas merged 2 commits intopantsbuild:mainfrom
tdyas:2.17.x_whats_new

Conversation

@tdyas
Copy link
Copy Markdown
Contributor

@tdyas tdyas commented May 26, 2023

Add initial draft of "What's New" section in v2.17.x release notes.

Comment thread src/python/pants/notes/2.17.x.md Outdated
For the `adhoc_tool` target type, the `stdout` and `stderr` fields are now specified relative to the applicable
workdir and also support absolute paths.

#### New: Javascript
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobni: Is the Javascript ready for mention in the release notes?

Are there other contributors who should be mentioned for this support?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a call for testing and/or disclaimer that it is in early stages? Theres some showstopper bugs in there which might frustrate...

Otherwise I believe this release contains test goal support and enables choice of package managers and a push for docker backend compatability (Ill have to double check though.)

I think 2.17 contains my contributions only, but @theoribeiro has helped me course correct.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobni : It would probably be good to create a "tracking ticket" that covers the issues you would like to see resolved before it is no longer experimental. It's a young convention (not actually documented anywhere yet), but useful for linking from various places.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a call for testing and/or disclaimer that it is in early stages? Theres some showstopper bugs in there which might frustrate...

Otherwise I believe this release contains test goal support and enables choice of package managers and a push for docker backend compatability (Ill have to double check though.)

Any preferred wording for these points?

Copy link
Copy Markdown
Contributor

@tobni tobni Jun 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the tracking ticket: #19240 @stuhood , I'll see if I can come up with a list of changes.

Comment thread src/python/pants/notes/2.17.x.md Outdated
Copy link
Copy Markdown
Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton for doing this @tdyas!

Comment on lines +7 to +11
The [`scie-pants` launcher binary](https://github.com/pantsbuild/scie-pants) is now the recommended way to run Pants.
Use of a `./pants` shell script in a repository is deprecated. Among other benefits, the `scie-pants` launcher is able
to automatically download and maintain a Python distribution for running Pants. It also allows you to run `pants`
from any directory within a repository and not just the build root. See the [Pants installation
instructions](https://www.pantsbuild.org/docs/installation) for additional information on how to migrate to `scie-pants.`
Copy link
Copy Markdown
Member

@stuhood stuhood May 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we now use the native client, 2.17.x runs using scie-pants with pantsd are also about 4.25x faster: #18957

Comment thread src/python/pants/notes/2.17.x.md Outdated
Comment thread src/python/pants/notes/2.17.x.md Outdated
For the `adhoc_tool` target type, the `stdout` and `stderr` fields are now specified relative to the applicable
workdir and also support absolute paths.

#### New: Javascript
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobni : It would probably be good to create a "tracking ticket" that covers the issues you would like to see resolved before it is no longer experimental. It's a young convention (not actually documented anywhere yet), but useful for linking from various places.

@tdyas tdyas force-pushed the 2.17.x_whats_new branch from 7bb5edf to 5f85521 Compare June 2, 2023 19:23
Comment thread src/python/pants/notes/2.17.x.md
Copy link
Copy Markdown
Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! That's some good stuff for a release that is largely a fast-follow to 2.16.x.

Copy link
Copy Markdown
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I've left some suggestions, but no particular attachment to them (E.g. I'm happy to work on the Lambda/GCF tweaks separately).

Potentially some other things that might be worth mentioning: 🤷‍♂️

  • docker auth: #18541, #18465
  • performance (both time and pantsd memory): #18153
  • some semi-breaking changes: #18930 (only breaking for weird uses of successive pants package runs), #18627 (hopefully people have followed the deprecations, but it seems like a major one?)

Comment thread src/python/pants/notes/2.17.x.md
Comment thread src/python/pants/notes/2.17.x.md
Comment thread src/python/pants/notes/2.17.x.md
Comment on lines +34 to +39
Pants now has _very early_ experimental support for Javascript thanks to ongoing efforts by Tobias Nilsson and
Theo Ribeiro. Please note that the Javascript backend is still incomplete, is being actively developed, and _probably
has critical bugs_. Despite that, the Pants maintainers would appreciate any feedback from the community to help
guide our development efforts.

Enable the `pants.backend.experimental.javascript` backend to try out this support. Please file issues at
https://github.com/pantsbuild/pants/issues/new/choose for any issues encountered.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Pants now has _very early_ experimental support for Javascript thanks to ongoing efforts by Tobias Nilsson and
Theo Ribeiro. Please note that the Javascript backend is still incomplete, is being actively developed, and _probably
has critical bugs_. Despite that, the Pants maintainers would appreciate any feedback from the community to help
guide our development efforts.
Enable the `pants.backend.experimental.javascript` backend to try out this support. Please file issues at
https://github.com/pantsbuild/pants/issues/new/choose for any issues encountered.
Pants now has _very early_ experimental support for Javascript thanks to ongoing efforts by Tobias Nilsson and
Theo Ribeiro. Please note that the Javascript backend is still incomplete, is being actively developed, and _probably
has critical bugs_. Despite that, the Pants maintainers would appreciate any feedback from the community to help
guide our development efforts.
Supported goals are:
* `test`: Letting you run tests via runners installed with the package manager of your choice.
* `package` goal, either to run a customized `package.json` script that produces an artifact via `node_build_script`, or to pack a tarball for npm-registry publication via the `npm_distribution` target.
* `tailor`: Generates build file targets for `*.js`, `*.test.js` and `package.json` files.
* `generate-lockfile`: Creates the lockfile in the format matching a projects package manager.
The backend supports all package managers provided by `corepack`. `yarn@v2` and [PlugNPlay](https://yarnpkg.com/features/pnp) is not supported.
Enable the `pants.backend.experimental.javascript` backend to try out this support. Please file issues at
https://github.com/pantsbuild/pants/issues/new/choose for any issues encountered, and follow along [the stabilization ticket on github](https://github.com/pantsbuild/pants/issues/19240).

Not sure how much prose should go here, but since there's no documentation (:see_no_evil:) maybe a list of what is possible helps encourage participation?

@thejcannon
Copy link
Copy Markdown
Member

From #19450 (comment), can you include a tidbit about how 2.17.x is the last stable release that will have a universal PEX uploaded? Instead we're switching to per-platform PEXs.

@tdyas
Copy link
Copy Markdown
Contributor Author

tdyas commented Jul 15, 2023

From #19450 (comment), can you include a tidbit about how 2.17.x is the last stable release that will have a universal PEX uploaded? Instead we're switching to per-platform PEXs.

Good point. Will do.

@huonw huonw added this to the 2.17.x milestone Aug 9, 2023
@benjyw
Copy link
Copy Markdown
Contributor

benjyw commented Aug 9, 2023

Let's merge this, and tweak it later if needed?

@tdyas
Copy link
Copy Markdown
Contributor Author

tdyas commented Aug 9, 2023

I just need to resolve the merge conflict.

@tdyas tdyas force-pushed the 2.17.x_whats_new branch from 0470b39 to cd623e8 Compare August 9, 2023 17:24
@tdyas tdyas enabled auto-merge (squash) August 9, 2023 17:25
@tdyas
Copy link
Copy Markdown
Contributor Author

tdyas commented Aug 9, 2023

I enabled auto-merge so should merge when CI passes.

@tdyas tdyas merged commit 0827127 into pantsbuild:main Aug 9, 2023
github-actions Bot pushed a commit that referenced this pull request Aug 10, 2023
Add initial draft of "What's New" section in v2.17.x release notes.
@WorkerPants
Copy link
Copy Markdown
Member

I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants.

✔️ 2.17.x

Successfully opened #19584.


Thanks again for your contributions!

🤖 Beep Boop here's my run link

benjyw pushed a commit to benjyw/pants that referenced this pull request Aug 13, 2023
Add initial draft of "What's New" section in v2.17.x release notes.
benjyw added a commit that referenced this pull request Aug 14, 2023
Add initial draft of "What's New" section in v2.17.x release notes.

Co-authored-by: Tom Dyas <tom.dyas@gmail.com>
huonw added a commit that referenced this pull request Aug 22, 2023
This adds a few additional notes to the "What's new" for 2.17, based on
some comments in #19168, as well as a skim of the release notes from
2.17.0rc0 and newer.

This also includes an explicit call out for the new sponsorship
strategy.
github-actions Bot pushed a commit that referenced this pull request Aug 22, 2023
This adds a few additional notes to the "What's new" for 2.17, based on
some comments in #19168, as well as a skim of the release notes from
2.17.0rc0 and newer.

This also includes an explicit call out for the new sponsorship
strategy.
huonw added a commit that referenced this pull request Aug 22, 2023
…19629) (#19642)

This adds a few additional notes to the "What's new" for 2.17, based on
some comments in #19168, as well as a skim of the release notes from
2.17.0rc0 and newer.

This also includes an explicit call out for the new sponsorship
strategy.

Co-authored-by: Huon Wilson <huon@exoflare.io>
@tdyas tdyas deleted the 2.17.x_whats_new branch October 5, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants