Ensure we set the AWS region.#19178
Merged
jsirois merged 1 commit intopantsbuild:mainfrom May 28, 2023
Merged
Conversation
This fix was found by Benjy in pantsbuild#18088 and here it just gets applied in a missed spot.
jsirois
added
the
category:internal
Contributor
Author
|
Tested this doesn't break the script via: $ AWS_ACCESS_KEY_ID=*** AWS_SECRET_ACCESS_KEY=*** build-support/bin/create_s3_index_file.sh a9e570fb1cae4e10ebfb9039f163841e59236f73
+ REGION=us-east-1
+ SHA=a9e570fb1cae4e10ebfb9039f163841e59236f73
+ WHEEL_DIR=binaries.pantsbuild.org/wheels/pantsbuild.pants
++ aws_s3 ls s3://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/
++ aws --region=us-east-1 s3 ls s3://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/
++ awk '{print $2}'
++ tr -d /
+ VERSION=2.18.0.dev0+gita9e570fb
+ VERSION_DIR=binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0+gita9e570fb
+ aws_s3 cp --acl=public-read --content-type=text/html - s3://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0+gita9e570fb/index.html
+ aws --region=us-east-1 s3 cp --acl=public-read --content-type=text/html - s3://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0+gita9e570fb/index.html
++ aws_s3 ls s3://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0+gita9e570fb/
++ grep '\.whl'
++ aws --region=us-east-1 s3 ls s3://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0+gita9e570fb/
++ awk '{print $4}'
+ for obj in $(aws_s3 ls "s3://${VERSION_DIR}/" | grep "\.whl" | awk '{print $4}')
+ URL=https://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0+gita9e570fb/pantsbuild.pants-2.18.0.dev0+gita9e570fb-cp39-cp39-linux_aarch64.whl
+ echo '<br><a href="https://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0%2Bgita9e570fb/pantsbuild.pants-2.18.0.dev0%2Bgita9e570fb-cp39-cp39-linux_aarch64.whl">pantsbuild.pants-2.18.0.dev0+gita9e570fb-cp39-cp39-linux_aarch64.whl</a>\n'
+ for obj in $(aws_s3 ls "s3://${VERSION_DIR}/" | grep "\.whl" | awk '{print $4}')
+ URL=https://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0+gita9e570fb/pantsbuild.pants-2.18.0.dev0+gita9e570fb-cp39-cp39-linux_x86_64.whl
+ echo '<br><a href="https://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0%2Bgita9e570fb/pantsbuild.pants-2.18.0.dev0%2Bgita9e570fb-cp39-cp39-linux_x86_64.whl">pantsbuild.pants-2.18.0.dev0+gita9e570fb-cp39-cp39-linux_x86_64.whl</a>\n'
+ for obj in $(aws_s3 ls "s3://${VERSION_DIR}/" | grep "\.whl" | awk '{print $4}')
+ URL=https://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0+gita9e570fb/pantsbuild.pants-2.18.0.dev0+gita9e570fb-cp39-cp39-macosx_10_15_x86_64.whl
+ echo '<br><a href="https://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0%2Bgita9e570fb/pantsbuild.pants-2.18.0.dev0%2Bgita9e570fb-cp39-cp39-macosx_10_15_x86_64.whl">pantsbuild.pants-2.18.0.dev0+gita9e570fb-cp39-cp39-macosx_10_15_x86_64.whl</a>\n'
+ for obj in $(aws_s3 ls "s3://${VERSION_DIR}/" | grep "\.whl" | awk '{print $4}')
+ URL=https://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0+gita9e570fb/pantsbuild.pants-2.18.0.dev0+gita9e570fb-cp39-cp39-macosx_11_0_arm64.whl
+ echo '<br><a href="https://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0%2Bgita9e570fb/pantsbuild.pants-2.18.0.dev0%2Bgita9e570fb-cp39-cp39-macosx_11_0_arm64.whl">pantsbuild.pants-2.18.0.dev0+gita9e570fb-cp39-cp39-macosx_11_0_arm64.whl</a>\n'
+ for obj in $(aws_s3 ls "s3://${VERSION_DIR}/" | grep "\.whl" | awk '{print $4}')
+ URL=https://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0+gita9e570fb/pantsbuild.pants.testutil-2.18.0.dev0+gita9e570fb-py3-none-any.whl
+ echo '<br><a href="https://binaries.pantsbuild.org/wheels/pantsbuild.pants/a9e570fb1cae4e10ebfb9039f163841e59236f73/2.18.0.dev0%2Bgita9e570fb/pantsbuild.pants.testutil-2.18.0.dev0%2Bgita9e570fb-py3-none-any.whl">pantsbuild.pants.testutil-2.18.0.dev0+gita9e570fb-py3-none-any.whl</a>\n' |
benjyw
approved these changes
May 28, 2023
github-actions Bot
pushed a commit
that referenced
this pull request
May 28, 2023
This fix was found by Benjy in #18088 and here it just gets applied in a missed spot.
stuhood
pushed a commit
that referenced
this pull request
May 30, 2023
Merged
Merged
wisechengyi
added a commit
that referenced
this pull request
Jun 4, 2023
### Internal * upgrade to Rust v1.70.0 ([#19228](#19228)) * Remove the last mentions of NO_TOOL_LOCKFILE. ([#19229](#19229)) * Upgrade Helm unittest ([#19220](#19220)) * Prepare `2.17.0rc0`. ([#19226](#19226)) * Use a trait for remote action result caching ([#19097](#19097)) * Port `Field` to Rust ([#19143](#19143)) * Upgrade `pyo3` to `0.19`. ([#19223](#19223)) * Prepare `2.16.0rc5`. ([#19221](#19221)) * internal: Create dep inference request type ([#19001](#19001)) * Avoid requiring Python when trying to install Python (using Pyenv) ([#19208](#19208)) * Fix secondary ownership warning semantics ([#19191](#19191)) * Bump os_pipe from 1.1.3 to 1.1.4 in /src/rust/engine ([#19202](#19202)) * Include committer date in local version identifier of unstable builds ([#19179](#19179)) * Ensure we set the AWS region. ([#19178](#19178))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix was found by Benjy in #18088 and here it just gets applied in
a missed spot.