Conversation
Signed-off-by: John McBride <john@papercompute.com>
|
| Filename | Overview |
|---|---|
| .github/workflows/pr.yaml | New workflow adding two Dagger-powered PR checks (title conformance and Linear magic word); remote module reference is unpinned and checkout steps appear unused. |
Sequence Diagram
sequenceDiagram
participant GH as GitHub (PR Event)
participant Runner as depot-ubuntu-24.04
participant DaggerCLI as Dagger CLI v0.20.6
participant Module as papercomputeco/daggerverse/ghcontrib
participant GHAPI as GitHub API
GH->>Runner: pull_request (opened/edited/synchronize/reopened)
par check-pr-title job
Runner->>Runner: actions/checkout@v4
Runner->>DaggerCLI: dagger/dagger-for-github@v8.2.0
Runner->>DaggerCLI: dagger call -m github.com/.../ghcontrib check-pull-request --number N
DaggerCLI->>Module: fetch module from GitHub (unversioned)
Module->>GHAPI: fetch PR #N details (GH_TOKEN)
GHAPI-->>Module: PR title
Module-->>DaggerCLI: pass / fail
DaggerCLI-->>Runner: exit 0 / exit 1
and check-linear-magic-word job
Runner->>Runner: actions/checkout@v4
Runner->>DaggerCLI: dagger/dagger-for-github@v8.2.0
Runner->>DaggerCLI: dagger call -m github.com/.../ghcontrib check-pull-request-linear-magic-word --number N
DaggerCLI->>Module: fetch module from GitHub (unversioned)
Module->>GHAPI: fetch PR #N body (GH_TOKEN)
GHAPI-->>Module: PR body
Module-->>DaggerCLI: pass / fail
DaggerCLI-->>Runner: exit 0 / exit 1
end
Comments Outside Diff (2)
-
.github/workflows/pr.yaml, line 34-38 (link)Unpinned remote Dagger module reference
Both
dagger callinvocations referencegithub.com/papercomputeco/daggerverse/ghcontribwithout a version tag or commit SHA. Dagger resolves this to the HEAD of the default branch, so any future commit toghcontribonmain— including breaking changes — immediately affects every in-flight PR check without any explicit upgrade step. Appending@<tag>or@<git-sha>would make the behaviour deterministic. The same applies to thecheck-linear-magic-wordjob at line 58.Prompt To Fix With AI
This is a comment left during a code review. Path: .github/workflows/pr.yaml Line: 34-38 Comment: **Unpinned remote Dagger module reference** Both `dagger call` invocations reference `github.com/papercomputeco/daggerverse/ghcontrib` without a version tag or commit SHA. Dagger resolves this to the HEAD of the default branch, so any future commit to `ghcontrib` on `main` — including breaking changes — immediately affects every in-flight PR check without any explicit upgrade step. Appending `@<tag>` or `@<git-sha>` would make the behaviour deterministic. The same applies to the `check-linear-magic-word` job at line 58. How can I resolve this? If you propose a fix, please make it concise.
-
.github/workflows/pr.yaml, line 23-25 (link)Checkout step likely unnecessary
Both jobs perform
actions/checkout@v4but immediately invoke Dagger with a fully-qualified remote module URL (github.com/papercomputeco/daggerverse/ghcontrib). Dagger fetches that module directly from GitHub rather than from the local workspace, so the checked-out source is never used. Removing the checkout step would shorten job startup by a few seconds. The same applies to the identical step incheck-linear-magic-word(line 47–49).Prompt To Fix With AI
This is a comment left during a code review. Path: .github/workflows/pr.yaml Line: 23-25 Comment: **Checkout step likely unnecessary** Both jobs perform `actions/checkout@v4` but immediately invoke Dagger with a fully-qualified remote module URL (`github.com/papercomputeco/daggerverse/ghcontrib`). Dagger fetches that module directly from GitHub rather than from the local workspace, so the checked-out source is never used. Removing the checkout step would shorten job startup by a few seconds. The same applies to the identical step in `check-linear-magic-word` (line 47–49). How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
.github/workflows/pr.yaml:34-38
**Unpinned remote Dagger module reference**
Both `dagger call` invocations reference `github.com/papercomputeco/daggerverse/ghcontrib` without a version tag or commit SHA. Dagger resolves this to the HEAD of the default branch, so any future commit to `ghcontrib` on `main` — including breaking changes — immediately affects every in-flight PR check without any explicit upgrade step. Appending `@<tag>` or `@<git-sha>` would make the behaviour deterministic. The same applies to the `check-linear-magic-word` job at line 58.
### Issue 2 of 2
.github/workflows/pr.yaml:23-25
**Checkout step likely unnecessary**
Both jobs perform `actions/checkout@v4` but immediately invoke Dagger with a fully-qualified remote module URL (`github.com/papercomputeco/daggerverse/ghcontrib`). Dagger fetches that module directly from GitHub rather than from the local workspace, so the checked-out source is never used. Removing the checkout step would shorten job startup by a few seconds. The same applies to the identical step in `check-linear-magic-word` (line 47–49).
Reviews (1): Last reviewed commit: "🧹 chore: Use daggerverse linear checker" | Re-trigger Greptile
Adds:
Towards CTO-33