feat: enable shell completions for standalone binary#74
Open
NormallyGaussian wants to merge 1 commit intomainfrom
Open
feat: enable shell completions for standalone binary#74NormallyGaussian wants to merge 1 commit intomainfrom
NormallyGaussian wants to merge 1 commit intomainfrom
Conversation
Remove the _STANDALONE_MODE guard from completion install. Click's _PARALLEL_CLI_COMPLETE env var is intercepted at the framework level before any command logic runs, so it works correctly in PyInstaller binaries.
NormallyGaussian
force-pushed
the
docs/shell-completions
branch
from
237ac85 to
c55ec9b
Compare
NormallyGaussian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_STANDALONE_MODEguard fromcompletion install, allowing shell completions to work in PyInstaller standalone binaries_PARALLEL_CLI_COMPLETEenv var is intercepted at the framework level before any command logic runs, so it works correctly regardless of install methodTest plan
parallel-cli completion installworks from a pip installparallel-cli completion installworks from a standalone binaryuv run pytest tests/test_cli.py -k completionto confirm test updates pass