Skip to content

Drop surface before reconfiguring it if texture is Suboptimal#451

Merged
parasyte merged 1 commit intoparasyte:mainfrom
abusch:push-qpuqutmotqpx
Apr 30, 2026
Merged

Drop surface before reconfiguring it if texture is Suboptimal#451
parasyte merged 1 commit intoparasyte:mainfrom
abusch:push-qpuqutmotqpx

Conversation

@abusch
Copy link
Copy Markdown
Contributor

@abusch abusch commented Apr 29, 2026

Apply the same fix as gfx-rs/wgpu#9384

closes: #450

@parasyte
Copy link
Copy Markdown
Owner

Looks good. Can you add a comment explaining the purpose of the drop? Since it's critical and there doesn't appear to be a way to test this, I don't want it to accidentally regress.

@abusch abusch force-pushed the push-qpuqutmotqpx branch from fadf701 to b21288b Compare April 29, 2026 13:49
@abusch
Copy link
Copy Markdown
Contributor Author

abusch commented Apr 29, 2026

Done.

@parasyte parasyte merged commit 7aead9f into parasyte:main Apr 30, 2026
10 checks passed
@parasyte
Copy link
Copy Markdown
Owner

Thank you! 0.17.1 was just published with this fix: https://crates.io/crates/pixels/0.17.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting wgpu ValidationError panic on Linux

2 participants