pkg/stack: Add benchmark for unwind table generation#925
Merged
javierhonduco merged 1 commit intomainfrom Oct 18, 2022
Merged
Conversation
``` $ go test -v github.com/parca-dev/parca-agent/pkg/stack/unwind -bench=. === RUN TestBuildUnwindTable --- PASS: TestBuildUnwindTable (0.00s) goos: linux goarch: amd64 pkg: github.com/parca-dev/parca-agent/pkg/stack/unwind cpu: Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz BenchmarkParsingLibcDwarfUnwindInformation BenchmarkParsingLibcDwarfUnwindInformation-12 58 57819288 ns/op 32710616 B/op 149598 allocs/op PASS ok github.com/parca-dev/parca-agent/pkg/stack/unwind 3.380s ``` Signed-off-by: Francisco Javier Honduvilla Coto <javierhonduco@gmail.com>
brancz
approved these changes
Oct 18, 2022
Member
brancz
left a comment
brancz
left a comment
There was a problem hiding this comment.
Nice!! At <100ms on relatively modern hardware I'm not worried for now that we need to think about trading off storage for CPU time.
javierhonduco
changed the title
Contributor
Author
|
This is just one dynamic library though. Will do some napkin math in the next couple of weeks to see what performance might look like for a big cluster w.r.t. the idea of backend-driven tables |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a benchmark for our table generation code to track its performance over time
cc @brancz @v-thakkar
Signed-off-by: Francisco Javier Honduvilla Coto javierhonduco@gmail.com