This repository was archived by the owner on Jun 30, 2022. It is now read-only.
Fixing the bench-bot after substrate changes#91
Merged
joao-paulo-parity merged 1 commit intoparitytech:masterfrom Apr 15, 2022
georgesdib:master
Merged
Fixing the bench-bot after substrate changes#91joao-paulo-parity merged 1 commit intoparitytech:masterfrom georgesdib:master
bench-bot after substrate changes#91joao-paulo-parity merged 1 commit intoparitytech:masterfrom
georgesdib:master
Conversation
Needed after substrate `benchmark` sub-command change PR paritytech/substrate#11164
ggwpez
approved these changes
Apr 15, 2022
Member
ggwpez
left a comment
ggwpez
left a comment
There was a problem hiding this comment.
Thanks we were just talking about this!
| "--features=runtime-benchmarks", | ||
| "--", | ||
| "benchmark", | ||
| "pallet", |
Member
There was a problem hiding this comment.
It could also be needed in Lines 328 and 419. Although I dont know what they do 😆
PS: Yea looks like it should be added, otherwise we expose the other commands as well.
Contributor
There was a problem hiding this comment.
From what I understand those are custom "run whatever" commands which could have a different subcommand other than pallet, so I think they can stay as they are. I don't know who's using them anyhow, perhaps @shawntabrizi can shed some light here.
In any case that should not block this PR and we can add it later if necessary.
Contributor
|
Thanks for the PR @georgesdib, let's merge this |
wischli
added a commit
to KILTprotocol/bench-bot
that referenced
this pull request
Jun 7, 2022
Fixing the `bench-bot` (paritytech#91)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed after substrate
benchmarksub-command changePR paritytech/substrate#11164
I believe this is what is needed now, but I am not sure.