This repository was archived by the owner on Feb 21, 2022. It is now read-only.
Conversation
riusricardo
approved these changes
Oct 30, 2020
Contributor
riusricardo
left a comment
riusricardo
left a comment
There was a problem hiding this comment.
I wanted to suggest this in order to remove the regression bug and simplify the tutorial. Andrew is always a few steps ahead 🎉
Contributor
Author
|
I was planning on keeping this as draft and only merging to master until the new release to crates.io. |
Contributor
|
I think that is is better to push an intermediate version. We only use Canvas in one tutorial and we can remove the friction that the regression bug is causing. Many new devs don't understand the issue and they are messing up with different nightly versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently tracking substrate master. Once a new version is released to crates.io we can update the dependencies.
Includes fixes which enable the runtime logging to work for contracts.