This repository was archived by the owner on Jan 21, 2025. It is now read-only.
make Command's job CI image configurable#217
Merged
Conversation
| const defaultVariables = parsedCommand.configuration.gitlab?.job.variables; | ||
| const overriddenVariables = parsedCommand.variables; | ||
| const configJobImage = parsedCommand.configuration.gitlab?.job.image; | ||
| let image: string = typeof configJobImage === "string" ? configJobImage : gitlab.defaultJobImage; |
Contributor
There was a problem hiding this comment.
wait, why do we specify image for all commands in this PR, while we still have gitlab.defaultJobImage; ?
Contributor
Author
There was a problem hiding this comment.
Well yea if there's a way to override a local command with -v CMD_IMAGE, and the main image is defined in "GITLAB_JOB_IMAGE" env, there's no need in "image" from .cmd.json
for CI team there will be 1 place to change it - in our repo, but it will require re-deployment (which is fine I think)
or if they wanna test it - then use CMD_IMAGE var
I am probably closing the PR in scripts paritytech/command-bot-scripts#42 and cleaning up these rows
alvicsam
approved these changes
Jul 18, 2023
mutantcornholio
approved these changes
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #211