This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Conversation
Forked at: 8b1fd65 Parent branch: origin/master
cecton
added
A3-inprogress
B0-silent
cecton
force-pushed
the
cecton-fix-int-test-3
branch
from
afc9ffa to
98479fd
Compare
Contributor
Author
|
The test is working. I just need to clean-up 😃 |
bkchr
reviewed
Jul 10, 2020
|
|
||
| // create and sign transaction | ||
| let wasm = fs::read(target_dir().join( | ||
| "wbuild/cumulus-test-parachain-runtime/cumulus_test_parachain_runtime.compact.wasm", |
Member
There was a problem hiding this comment.
Nope ;)
Please import the runtime and use the WASM_BINARY directly. This is the reason this constant exists.
|
|
||
| // Adapted from | ||
| // https://github.com/rust-lang/cargo/blob/485670b3983b52289a2f353d589c57fae2f60f82/tests/testsuite/support/mod.rs#L507 | ||
| fn target_dir() -> PathBuf { |
| let t2 = async { | ||
| let para_id = ParaId::from(100); | ||
|
|
||
| future::join(alice.wait_for_blocks(2_usize), bob.wait_for_blocks(2_usize)).await; |
Member
There was a problem hiding this comment.
Suggested change
| future::join(alice.wait_for_blocks(2_usize), bob.wait_for_blocks(2_usize)).await; | |
| future::join(alice.wait_for_blocks(2), bob.wait_for_blocks(2)).await; |
| pin_mut!(t1, t2); | ||
|
|
||
| select! { | ||
| _ = t1 => { |
Member
There was a problem hiding this comment.
In general this is something that could be moved to polkadot-test-service as helper function. Especially the generation of t1.
Contributor
Author
There was a problem hiding this comment.
🤔 you mean to substrate no? I could probably make a macro to will also handle the runtime using tokio like tokio::test but substrate::test (will do async + timeout for the test)
Contributor
Author
There was a problem hiding this comment.
I made this PR to address this: paritytech/substrate#6651
bkchr
approved these changes
Jul 23, 2020
Maharacha
pushed a commit
to Maharacha/cumulus
that referenced
this pull request
May 10, 2023
* bump encointer-pallets * [chain_spec] rename ceremony phase values to CamelCase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108