[Enhancement] Use XCM V3 for initiate_teleport weight calc by ruseinov · Pull Request #2102 · paritytech/cumulus

ruseinov · 2023-01-17T11:41:33Z

KiChjang · 2023-02-07T22:49:47Z

parachains/runtimes/assets/statemine/src/weights/xcm/mod.rs

-			Self::Wild(_) => weight.saturating_mul(MAX_ASSETS as u64),
+			Self::Wild(asset) => match asset {
+				All => weight.saturating_mul(MAX_ASSETS as u64),
+				AllOf { .. } => weight,


I'm actually still uncertain about this -- comments on AllOfCounted says that each individual instance of an NFT is considered a different class of asset, and so wouldn't it make more sense to use the number of NFT instances as an upper bound here?

Hmm, good question. Let me check it out and come back to you.

Yeah, I think this makes sense. I'm not sure though where the NFT instance count should be coming from in this case.

So this requires you to actually look inside the holding register and determine just how many AssetInstances there are... We could match against fun in AllOf and see if it's a NonFungible, and if so, it would basically be weight * MaxAssetsIntoHolding::get(), otherwise it's just weight.

@KiChjang One thing that disturbs me a bit is the comment below, should we then do something like weight * MaxAssetsIntoHolding::get() * 2 to be safe?

/// The maximum number of assets we target to have in the Holding Register at any one time. /// /// NOTE: In the worse case, the Holding Register may contain up to twice as many assets as this /// and any benchmarks should take that into account. type MaxAssetsIntoHolding: Get<u32>;

ruseinov · 2023-02-09T12:01:15Z

bot rebase

…tinit-teleport

paritytech-processbot · 2023-02-09T12:01:22Z

Rebased

ruseinov · 2023-02-09T14:23:26Z

bot merge

paritytech-processbot · 2023-02-09T14:23:34Z

Waiting for commit status.

* [Enhancement] Use XCM V3 for initiate_teleport weight calc * deref * replicate in all the runtimes * fmt * better handling for AllOf * fmt * small type fix * replicate the fix for all runtimes --------- Co-authored-by: parity-processbot <>

) * Wwstmint test for ReceiveTeleportedAsset * Missing fix for `weigh_multi_assets` * Added tests for statemine/statemint * [Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102) * [Enhancement] Use XCM V3 for initiate_teleport weight calc * deref * replicate in all the runtimes * fmt * better handling for AllOf * fmt * small type fix * replicate the fix for all runtimes --------- Co-authored-by: parity-processbot <> * removed `frame_support::sp_tracing::try_init_simple();` * Review fixes * Removed `as u64` --------- Co-authored-by: Roman Useinov <roman.useinov@gmail.com>

) (#2239) * Wwstmint test for ReceiveTeleportedAsset * Missing fix for `weigh_multi_assets` * Added tests for statemine/statemint * [Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102) * [Enhancement] Use XCM V3 for initiate_teleport weight calc * deref * replicate in all the runtimes * fmt * better handling for AllOf * fmt * small type fix * replicate the fix for all runtimes --------- Co-authored-by: parity-processbot <> * removed `frame_support::sp_tracing::try_init_simple();` * Review fixes * Removed `as u64` --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Roman Useinov <roman.useinov@gmail.com>

) (#2240) * Wwstmint test for ReceiveTeleportedAsset * Missing fix for `weigh_multi_assets` * Added tests for statemine/statemint * [Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102) * [Enhancement] Use XCM V3 for initiate_teleport weight calc * deref * replicate in all the runtimes * fmt * better handling for AllOf * fmt * small type fix * replicate the fix for all runtimes --------- Co-authored-by: parity-processbot <> * removed `frame_support::sp_tracing::try_init_simple();` * Review fixes * Removed `as u64` --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Roman Useinov <roman.useinov@gmail.com>

) (#2238) * Wwstmint test for ReceiveTeleportedAsset * Missing fix for `weigh_multi_assets` * Added tests for statemine/statemint * [Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102) * [Enhancement] Use XCM V3 for initiate_teleport weight calc * deref * replicate in all the runtimes * fmt * better handling for AllOf * fmt * small type fix * replicate the fix for all runtimes --------- Co-authored-by: parity-processbot <> * removed `frame_support::sp_tracing::try_init_simple();` * Review fixes * Removed `as u64` --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Roman Useinov <roman.useinov@gmail.com>

…2102)" This reverts commit 8230ec4.

* Revert "[Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102)" This reverts commit 8230ec4. * updating weight format * We expect to pay 1bn+ for a teleport at the current weights. * The test isn't needed and hardcoded scale is hand to maintain. * remove unused imports --------- Co-authored-by: Giles Cope <gilescope@gmail.com>

…2402) * Revert "[Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102)" This reverts commit 8230ec4. * updating weight format * We expect to pay 1bn+ for a teleport at the current weights. * The test isn't needed and hardcoded scale is hand to maintain. * remove unused imports --------- Co-authored-by: Giles Cope <gilescope@gmail.com>

…2403) * Revert "[Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102)" This reverts commit 8230ec4. * updating weight format * We expect to pay 1bn+ for a teleport at the current weights. * The test isn't needed and hardcoded scale is hand to maintain. * remove unused imports --------- Co-authored-by: Giles Cope <gilescope@gmail.com>

[Enhancement] Use XCM V3 for initiate_teleport weight calc

16cd773

ruseinov requested review from ggwpez and joepetrowski January 17, 2023 11:41

ruseinov self-assigned this Jan 17, 2023

deref

202b067

ruseinov requested a review from KiChjang January 31, 2023 13:09

ruseinov added 2 commits February 5, 2023 15:11

replicate in all the runtimes

3fe90ae

fmt

1f884d1

gavofyork approved these changes Feb 7, 2023

View reviewed changes

gilescope approved these changes Feb 7, 2023

View reviewed changes

KiChjang reviewed Feb 7, 2023

View reviewed changes

better handling for AllOf

9201905

Merge remote-tracking branch 'origin/master' into ru/enhancement/iini…

904db9e

…tinit-teleport

ruseinov added 3 commits February 9, 2023 13:07

fmt

e59c552

small type fix

0cf2bac

replicate the fix for all runtimes

bdd401e

paritytech-processbot bot merged commit 8230ec4 into master Feb 9, 2023

paritytech-processbot bot deleted the ru/enhancement/iinitinit-teleport branch February 9, 2023 15:01

EgorPopelyaev mentioned this pull request Feb 27, 2023

[Backport] of Tests + backport fix for teleport_assets (ReceiveTeleportedAsset) (#2… #2238

Merged

EgorPopelyaev mentioned this pull request Feb 27, 2023

[Backport] Tests + backport fix for teleport_assets (ReceiveTeleportedAsset) (#2… #2239

Merged

EgorPopelyaev mentioned this pull request Feb 27, 2023

[Backport] Tests + backport fix for teleport_assets (ReceiveTeleportedAsset) (#2… #2240

Merged

gilescope mentioned this pull request Mar 28, 2023

Expensive teleports #2392

Closed

EgorPopelyaev added a commit that referenced this pull request Mar 28, 2023

Revert "[Enhancement] Use XCM V3 for initiate_teleport weight calc (#…

83dbea9

…2102)" This reverts commit 8230ec4.

EgorPopelyaev mentioned this pull request Mar 28, 2023

[Revert] Use XCM V3 for initiate_teleport weight calc #2102 #2394

Merged

kiltbot mentioned this pull request Apr 3, 2023

[AUTOMATIC] Update Polkadot dependencies from 0.9.38 to 0.9.39 KILTprotocol/kilt-node#495

Closed

librelois mentioned this pull request Apr 6, 2023

Update substrate/polkadot/cumulus from v0.9.38 to v0.9.40 moonbeam-foundation/moonbeam#2200

Closed

al3mart mentioned this pull request Feb 25, 2025

feat(mainnet): include xcm benchmarks r0gue-io/pop-node#479

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enhancement] Use XCM V3 for initiate_teleport weight calc#2102

[Enhancement] Use XCM V3 for initiate_teleport weight calc#2102
paritytech-processbot[bot] merged 9 commits intomasterfrom
ru/enhancement/iinitinit-teleport

ruseinov commented Jan 17, 2023 •

edited

Loading

Uh oh!

KiChjang Feb 7, 2023

Uh oh!

ruseinov Feb 8, 2023

Uh oh!

ruseinov Feb 8, 2023 •

edited

Loading

Uh oh!

KiChjang Feb 8, 2023

Uh oh!

ruseinov Feb 9, 2023

Uh oh!

ruseinov Feb 9, 2023

Uh oh!

ruseinov commented Feb 9, 2023

Uh oh!

paritytech-processbot bot commented Feb 9, 2023

Uh oh!

ruseinov commented Feb 9, 2023

Uh oh!

paritytech-processbot bot commented Feb 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ruseinov commented Jan 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KiChjang Feb 7, 2023

Choose a reason for hiding this comment

Uh oh!

ruseinov Feb 8, 2023

Choose a reason for hiding this comment

Uh oh!

ruseinov Feb 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KiChjang Feb 8, 2023

Choose a reason for hiding this comment

Uh oh!

ruseinov Feb 9, 2023

Choose a reason for hiding this comment

Uh oh!

ruseinov Feb 9, 2023

Choose a reason for hiding this comment

Uh oh!

ruseinov commented Feb 9, 2023

Uh oh!

paritytech-processbot bot commented Feb 9, 2023

Uh oh!

ruseinov commented Feb 9, 2023

Uh oh!

paritytech-processbot bot commented Feb 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ruseinov commented Jan 17, 2023 •

edited

Loading

ruseinov Feb 8, 2023 •

edited

Loading