This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Benchmarks script improvements#2214
Merged
paritytech-processbot[bot] merged 3 commits intomasterfrom Feb 21, 2023
Merged
Conversation
muharem
added
B0-silent
bkontur
reviewed
Feb 21, 2023
| repeat=${5:-20} | ||
|
|
||
| benchmarkOutput=./parachains/runtimes/$category/$runtimeName/src/weights | ||
| benchmarkRuntimeName="$runtimeName-dev" |
Contributor
There was a problem hiding this comment.
@muharem
what about renaming benchmarkRuntimeName -> benchmarkRuntimeChain ?
Contributor
There was a problem hiding this comment.
runtimes have names. chains are run by nodes and run runtimes.
EgorPopelyaev
approved these changes
Feb 21, 2023
bkontur
approved these changes
Feb 21, 2023
Contributor
bkontur
left a comment
bkontur
left a comment
There was a problem hiding this comment.
very nice to remove those IFs :)
Contributor
Author
|
bot rebase |
|
Rebased |
Contributor
Author
|
bot merge |
|
Waiting for commit status. |
gilescope
reviewed
Feb 21, 2023
| cut -d',' -f1 |\ | ||
| sort |\ | ||
| uniq | ||
| )) |
Contributor
There was a problem hiding this comment.
this is assuming that all pallets will get benchmarked. Just wondering if there's any pallets left that we currently still use hardcoded substrate weights from? I guess if you've run this for low repetitions and had no trouble then this should be fine.
Contributor
Author
There was a problem hiding this comment.
no, it does not. if the pallet not listed in define_benchmarks macro, it wont be returned by the command
gilescope
approved these changes
Feb 21, 2023
ordian
added a commit
that referenced
this pull request
Feb 27, 2023
* master: (35 commits) add turboflakes system-chains bootnodes (#2223) Companion for #13349 (#2217) bump `zombienet` version to v1.3.35 (#2226) [ci] Return benchmark to bm machines (#2225) Collectives chain xcm filter (#2222) Add metaspan.io parachain boot nodes (#2218) Companion for #13390 (#2189) `BlockId` removal: `BlockBuilderProvider::new_block_at` (#2219) Benchmarks script improvements (#2214) `BlockId` removal: refactor of runtime API (#2190) Rename .feature extension to .zndsl (#2215) Companion for paritytech/polkadot#6744: Retire `OldV1SessionInfo` (#2213) WIP: Fix templates (#2204) Add stake.plus bootnodes to collectives-westend and bridge-hub-kusama (#2201) Polkadot companion #6603: Use a `BoundedVec` in `ValidationResult` (#2161) Bump clap from 4.1.4 to 4.1.6 (#2193) Bump toml from 0.6.0 to 0.7.2 (#2170) companion for paritytech/polkadot#6161 (#2151) Bump serde_json from 1.0.92 to 1.0.93 (#2175) add warp_sync_params (#1909) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The updated scripts are backward compatible.
Updates: