Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Companion for Soft deprecate GenesisConfig#2636

Merged
paritytech-processbot[bot] merged 5 commits intomasterfrom
jg/14065-companion-for-deprecation-genesisconfig-runtimegenesisconfig
Jun 16, 2023
Merged

Companion for Soft deprecate GenesisConfig#2636
paritytech-processbot[bot] merged 5 commits intomasterfrom
jg/14065-companion-for-deprecation-genesisconfig-runtimegenesisconfig

Conversation

@juangirini
Copy link
Contributor

@juangirini juangirini commented May 25, 2023 •
edited
Loading

@juangirini juangirini added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. A4-companion A PR that should be considered alongside another (usually more comprehensive and detailed) PR. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 25, 2023
@juangirini juangirini requested review from a team, bkontur, gilescope and joepetrowski May 25, 2023 07:40
@juangirini juangirini mentioned this pull request May 25, 2023
Merged
@juangirini juangirini changed the title Companion for Soft deprecate GenesisConfig [WIP] Companion for Soft deprecate GenesisConfig May 25, 2023
@juangirini juangirini added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels May 25, 2023
@juangirini juangirini mentioned this pull request May 25, 2023
Merged
@juangirini juangirini changed the title [WIP] Companion for Soft deprecate GenesisConfig draft: Companion for Soft deprecate GenesisConfig May 25, 2023
@juangirini juangirini changed the title draft: Companion for Soft deprecate GenesisConfig [WIP] Companion for Soft deprecate GenesisConfig May 25, 2023
@muharem
Copy link
Contributor

muharem commented May 26, 2023

bot rebase

Merge remote-tracking branch 'origin/master' into jg/14065-companion-…
5ad1d51 
…for-deprecation-genesisconfig-runtimegenesisconfig
@paritytech-processbot
Copy link

paritytech-processbot bot commented May 26, 2023

Rebased

@juangirini juangirini changed the title [WIP] Companion for Soft deprecate GenesisConfig Companion for Soft deprecate GenesisConfig May 26, 2023
@juangirini
Copy link
Contributor Author

juangirini commented Jun 16, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 645326a into master Jun 16, 2023
@paritytech-processbot paritytech-processbot bot deleted the jg/14065-companion-for-deprecation-genesisconfig-runtimegenesisconfig branch June 16, 2023 11:05
@darkforest0202 darkforest0202 mentioned this pull request Jun 21, 2023
Closed
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bkontur bkontur Awaiting requested review from bkontur

@joepetrowski joepetrowski Awaiting requested review from joepetrowski

4 more reviewers

@gilescope gilescope gilescope approved these changes

@sam0x17 sam0x17 sam0x17 approved these changes

@bkchr bkchr bkchr approved these changes

@ggwpez ggwpez ggwpez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A3-in_progress Pull request is in progress. No review needed at this stage. A4-companion A PR that should be considered alongside another (usually more comprehensive and detailed) PR. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@juangirini @muharem @gilescope @sam0x17 @bkchr @ggwpez @joepetrowski