Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Fix rococo-parachain-runtime build#887

Merged
paritytech-processbot[bot] merged 1 commit intomasterfrom
skunert-fix-rococo-deps
Jan 5, 2022
Merged

Fix rococo-parachain-runtime build#887
paritytech-processbot[bot] merged 1 commit intomasterfrom
skunert-fix-rococo-deps

Conversation

@skunert
Copy link
Contributor

@skunert skunert commented Jan 5, 2022

Command cargo build -p rococo-parachain-runtime broke after #835.

I found that we are missing some entries in polkadot-parachains/rococo-parachain/Cargo.toml, I am not sure why it worked before however.

Additionally, I add client/relay-chain-local to the workspace.

@skunert skunert added A0-pleasereview B0-silent Changes should not be mentioned in any release notes labels Jan 5, 2022
@skunert skunert requested a review from bkchr January 5, 2022 12:57
@bkchr
Copy link
Member

bkchr commented Jan 5, 2022

I am not sure why it worked before however.

It worked because you compiled the workspace. If you enable a feature in the workspace, it is enabled everywhere automatically.

@bkchr
Copy link
Member

bkchr commented Jan 5, 2022

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit e9e775f into master Jan 5, 2022
@paritytech-processbot paritytech-processbot bot deleted the skunert-fix-rococo-deps branch January 5, 2022 13:30
CaptainVincent added a commit to CaptainVincent/cumulus that referenced this pull request Feb 20, 2022
bkchr pushed a commit that referenced this pull request Feb 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

B0-silent Changes should not be mentioned in any release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants