This repository was archived by the owner on Nov 15, 2023. It is now read-only.
xcmp-queue: Fix handling of encoded blobs#889
Merged
Conversation
With #701 we tried to fix some infinite loop related to encoded blobs, however that lead actually to not being able to process encoded blobs at all. The reason for this is that `decode_all` doesn't consume the given input. The point of this function is that it returns an error if the data couldn't be decoded or there is still data left. However, this means that the check `remaining_fragments.len() < last_remaining_fragments.len()` would always fail. We remove the while loop, because we decode the entire fragment anyway or it fails. Aka, we don't need to loop here. Next we remove the broken check and we directly reset the `remaining_fragments` (because `decode_all` doesn't consume anything).
bkchr
added
A0-pleasereview
B0-silent
Contributor
|
Can we do a similar thing with the XcmpMessageFormat::ConcatenatedVersionedXcm case? |
Member
Author
This is not required. |
We need to use a while loop, because there can be multiple `Vec<u8>`s. We also need to use `decode`, because `decode_all` would otherwise return an error if the input is not empty afterwards.
KiChjang
reviewed
Jan 12, 2022
KiChjang
approved these changes
Jan 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #701 we tried to fix some infinite loop related to encoded blobs, however that lead actually to
not being able to process encoded blobs at all. The reason for this is that
decode_alldoesn'tconsume the given input. The point of this function is that it returns an error if the data couldn't
be decoded or there is still data left. However, this means that the check
remaining_fragments.len() < last_remaining_fragments.len()would always fail.We remove the while loop, because we decode the entire fragment anyway or it fails. Aka, we don't
need to loop here. Next we remove the broken check and we directly reset the
remaining_fragments(becausedecode_alldoesn't consume anything).