Conversation
Contributor
|
looks great! TIL about the |
insipx
approved these changes
Dec 1, 2020
Contributor
|
@insipx the CI seems angry for the wrong reasons. Do you know how to kick it in the balls? |
Contributor
|
@dvdplm I have no idea 😅 i've never had CLA crap out before. Merge is greyed out for me -- maybe we need an admin to push it through? |
Contributor
Author
|
I'm not sure what the CI issues other than CLA are about. Anything that I can do per se? |
Contributor
|
It looks like the substrate revision is too old to build with nightly rust. |
Contributor
Contributor
Author
|
merged with master, hopefully can merge now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking into the code a bit and decided to fix this
TODO.I am looking more into using desub and eventually contributing back. Pointing me out to further small issues could potentially end up in them being resolved by me.
Only substantial change of this PR is that aside from hardcoding the number of transactions in each block, we use the count of files with a certain prefix (which I am not sure why it wasn't like this from the get go? maybe I am missing a reason here.)