Changes needed for substrate#4612#104
Changes needed for substrate#4612#104rphmeier merged 10 commits intoparitytech:masterfrom expenses:future
Conversation
|
It looks like @expenses signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
That is pretty unergonomic. Can you explain the rationale? |
|
@rphmeier I've added rand back as a |
|
@rphmeier I need to test that. |
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
=========================================
Coverage ? 89.09%
=========================================
Files ? 10
Lines ? 3155
Branches ? 0
=========================================
Hits ? 2811
Misses ? 344
Partials ? 0
Continue to review full report at Codecov.
|
|
Solve conflicts, then merge here. Thanks! |
|
We'll need to publish a new GRANDPA version; cc @andresilva |
See paritytech/substrate#4612. This merges in #100, but also:
randto be dependent on thetest-helpersfeature, which means that the crate actually compiles with this feature turned on. This does mean that you have to runcargo test --feature test-helpersto test it though.Unpinimpl for a few types.