Put all mobx stores in this repo?

[amaury1093]

When I needed a mobx store in a dapp, I either:

• took it from this repo (e.g. @parity/shared/lib/mobx/dappsStore)
• took it from js-ui (e.g. @parity/ui/lib/DappVouchFor/store)
• wrote it myself again

Proposal: If we do decide to go mobx all the way, then we could have a bunch of small mobx stores, all in this repo. Maybe one store per get/set pair in methodGroups.

This would probably overlap with oo7, so we should avoid redundancy. Maybe start with shell methods.

[jacogr]

Like the idea. At the same time, I believe this repo is overly bloated and have a lot of stuff we are trying to get rid of. Maybe a better idea is a js-stores repo (or something similar) than can fill the gap? (And contains the stuff actually used, so I wouldn't just blindly move all)

[amaury1093]

On MobX Stores

I see 2 types of MobX stores, and these 2 are quite mixed together right now:

1. Mobx stores that will be used by dapps. E.g. shell_getApps, parity_accountsInfo etc are apis often called by dapps, there should be a MobX store which manages these API calls and their results. These stores should go into https://github.com/paritytech/js-mobx.
2. Mobx stores that are only accessible by the shell. These stores should handle LocalStorage saving. It wouldn't make sense to put in js-mobx a store which sets something into LS, because a dapp could import this store and bypass the shell requests in the orange bar. These stores should go into the shell.

On cleaning this repo

Here's where I think should go the stores in this repo:

• dappsStore: This store is too big and should be split. Apps and displayApps should go into separate stores in js-mobx, modalOpen and externalOverlayVisible in the shell
• extensionStore: should go into the extension?
• hardwareStore: js-mobx.
• historyStore: shell, it saves stuff to LS. One day in js-mobx if we implement a shell_getHistory.
• signerStore: js-mobx.
• upgradeStore: shell, it saves stuff to LS.

Long term vision

• Each time a dapp needs a Mobx store that does an api call, then create a store in js-mobx.
• Slowly put shell-specific stores into the shell directly.
• Delete this repo.