Merged
Conversation
Contributor
|
PR description please? |
dvdplm
approved these changes
Oct 15, 2019
Contributor
dvdplm
left a comment
There was a problem hiding this comment.
lgtm but a test would be nice.
tcp/src/server.rs
Outdated
| let peer_addr = match socket.peer_addr() { | ||
| Ok(addr) => addr, | ||
| Err(e) => { | ||
| trace!(target: "tcp", "Unable to determine socket peer address, ignoring connection {}", e); |
Contributor
There was a problem hiding this comment.
Suggested change
| trace!(target: "tcp", "Unable to determine socket peer address, ignoring connection {}", e); | |
| warn!(target: "tcp", "Unable to determine socket peer address, ignoring connection {}", e); |
Contributor
|
@seunlanlege after this gets merged please update the version number and release a new version on |
tomusdrw
approved these changes
Oct 15, 2019
Contributor
tomusdrw
left a comment
There was a problem hiding this comment.
lgtm, just address David's grumble.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously If there's no
peer_addron the socket, this causes the tcp-server to panic.jsonrpc/tcp/src/server.rs
Lines 87 to 93 in 4418476
Instead of panicking this PR instead ignores the connection as it has most likely been dropped by the client.
closes #500