monorepo labels draft by the-right-joyce · Pull Request #29 · paritytech/labels

the-right-joyce · 2023-05-09T21:48:13Z

related to #25
this PR should serve solely to have a proposal and discussion about the new labels for the monorepo

this PR here should just serve to have a proposal and discussion about the new labels for the monorepo

ruled_labels/[DRAFT]specs_monorepo.yaml

the-right-joyce · 2023-05-09T21:52:15Z

ruled_labels/[DRAFT]specs_monorepo.yaml

+    color: 5319e7
+  - name: T9-polkadot
+    description: This PR/Issue is related to/affects Polkadot.
+    color: ffeeee


do we need to specify this here more? like: relay chain, collators, staking, etc.?

ruled_labels/[DRAFT]specs_monorepo.yaml

juangirini · 2023-05-10T08:11:42Z

No Status nor Urgency labels 😍

ruled_labels/[DRAFT]specs_monorepo.yaml

koute · 2023-05-10T10:11:20Z

ruled_labels/[DRAFT]specs_monorepo.yaml

+  - name: I10-optimisation
+    description: An enhancement to provide better overall performance in terms of time-to-completion for a task.
+    color: c5def5


I'd like to have two labels here: one for CPU optimization, and one for memory usage optimizations.

would it be enough if you use I10-optimisation with a T* label? Then I'd add there T12-CPU and T13-memory_usage? And you can then mix and match with other labels, like: bug, annoyance, etc.

koute · 2023-05-10T10:14:40Z

@the-right-joyce Are these labels only supposed to be for PRs, or also for the issues? I think it'd probably make sense to have separate sets of labels for both.

ruled_labels/[DRAFT]specs_monorepo.yaml

changes based on comments: b > breaking changes c > complexity labels f removed A6 moved to I11 host function labels updated deprecation label added benchmark added

michalkucharczyk

looks good. left some nitpicks.

ruled_labels/[DRAFT]specs_monorepo.yaml

juangirini · 2023-05-15T13:14:20Z

@the-right-joyce Are these labels only supposed to be for PRs, or also for the issues? I think it'd probably make sense to have separate sets of labels for both.

I'd like to back up this idea, I think issues and prs are many times mixed up, and having different labels for those would be a great step into separating them

the-right-joyce · 2023-05-19T11:35:29Z

@juangirini we can define this with the ruled labels tool from @chevdor
A and B are def PR labels
C and I are issue labels
T is for both

- Delete D* labels - Add RnD for Tax-Department - Merge wont fix/invalid

ruled_labels/[DRAFT]specs_monorepo.yaml

kianenigma

Seems like we have no audit labels anymore. All good, but do we have a replacement system in mind?

juangirini · 2023-05-23T09:55:59Z

Seems like we have no audit labels anymore. All good, but do we have a replacement system in mind?

We'll use a project to track audit issues #29 (comment)

Co-authored-by: Juan <juangirini@gmail.com>

chevdor · 2023-05-30T13:03:25Z

We'll use a project to track...

Today, we are using the Audit labels to inform readers of the release notes about what has been audited, what does ont require aurditing, etc... Is it planned to drop this feature ?

the-right-joyce · 2023-05-30T14:07:21Z

yes

ruled_labels/[DRAFT]specs_monorepo.yaml

sam0x17 · 2023-06-15T11:06:20Z

@juangirini we can define this with the ruled labels tool from @chevdor A and B are def PR labels C and I are issue labels T is for both

for clarity, I would be in support of prefixing PR-related labels with PR- and issue-related labels with I-. That way you can just look down the list alphabetically and apply each category of label relevant to whether you are doing a PR or an issue and feel confident that you hit every category.

This doesn't help with the shared T labels but it will make everything else more clear

bkchr · 2023-06-15T21:12:10Z

feel confident that you hit every category.

You are trying to workaround the fact that there are too many labels and they are not explained. This should hopefully not be the case anymore with these refactoring.

…paritytech/labels into the-right-joyce-monorepo-labels

ruled_labels/[DRAFT]specs_monorepo.yaml

kianenigma

In the mono-repo, I suggest we break the. T1-Runtime into two buckets:

T1-FRAME (changes to core frame, the framework, not a particular pallet)
T2-Pallets (changes to a particular pallet, possibly used by others)

for example now in PBA I want to report the latest changes in FRAME the framework to Shawn to update himself, but filtering by T1-Runtime is super noisy, contains million patches to random pallets that are unrelated to the FRAME itself.

monorepo labels draft

a381db5

this PR here should just serve to have a proposal and discussion about the new labels for the monorepo

the-right-joyce commented May 9, 2023

View reviewed changes

ruled_labels/[DRAFT]specs_monorepo.yaml Outdated Show resolved Hide resolved

the-right-joyce commented May 9, 2023

View reviewed changes

ruled_labels/[DRAFT]specs_monorepo.yaml Outdated Show resolved Hide resolved

the-right-joyce commented May 9, 2023

View reviewed changes

the-right-joyce requested review from alvicsam, bkchr, ggwpez, juangirini and kianenigma May 9, 2023 21:54

update date

9f39fd0

juangirini reviewed May 10, 2023

View reviewed changes

ruled_labels/[DRAFT]specs_monorepo.yaml Outdated Show resolved Hide resolved

juangirini reviewed May 10, 2023

View reviewed changes

ruled_labels/[DRAFT]specs_monorepo.yaml Outdated Show resolved Hide resolved

the-right-joyce requested a review from joepetrowski May 10, 2023 09:15

the-right-joyce commented May 10, 2023

View reviewed changes

ruled_labels/[DRAFT]specs_monorepo.yaml Outdated Show resolved Hide resolved

koute reviewed May 10, 2023

View reviewed changes

ruled_labels/[DRAFT]specs_monorepo.yaml Outdated Show resolved Hide resolved

koute reviewed May 10, 2023

View reviewed changes

ruled_labels/[DRAFT]specs_monorepo.yaml Outdated Show resolved Hide resolved

koute reviewed May 10, 2023

View reviewed changes

ggwpez reviewed May 10, 2023

View reviewed changes

update

f8a2483

changes based on comments: b > breaking changes c > complexity labels f removed A6 moved to I11 host function labels updated deprecation label added benchmark added

michalkucharczyk reviewed May 15, 2023

View reviewed changes

ruled_labels/[DRAFT]specs_monorepo.yaml Outdated Show resolved Hide resolved

ruled_labels/[DRAFT]specs_monorepo.yaml Outdated Show resolved Hide resolved

michalkucharczyk reviewed May 15, 2023

View reviewed changes

ruled_labels/[DRAFT]specs_monorepo.yaml Outdated Show resolved Hide resolved

juangirini mentioned this pull request May 18, 2023

Create new deprecation label #28

Closed

the-right-joyce added 4 commits May 19, 2023 10:21

Update

8a2a8e1

- Delete D* labels - Add RnD for Tax-Department - Merge wont fix/invalid

Update A* labels

e0b6cc9

delete C5-reserved

9c533b2

update R&D label

e8ee30b

the-right-joyce added 2 commits May 20, 2023 11:25

add system parachains to topics

e721d65

update topics

b5b5ae6

bkchr reviewed May 20, 2023

View reviewed changes

ruled_labels/[DRAFT]specs_monorepo.yaml Show resolved Hide resolved

ruled_labels/[DRAFT]specs_monorepo.yaml Outdated Show resolved Hide resolved

ruled_labels/[DRAFT]specs_monorepo.yaml Outdated Show resolved Hide resolved

kianenigma mentioned this pull request May 23, 2023

add new documentation guidelines paritytech/substrate#14115

Merged

juangirini reviewed May 23, 2023

View reviewed changes

ruled_labels/[DRAFT]specs_monorepo.yaml Outdated Show resolved Hide resolved

juangirini linked an issue May 23, 2023 that may be closed by this pull request

Create new deprecation label #28

Closed

kianenigma reviewed May 23, 2023

View reviewed changes

ruled_labels/[DRAFT]specs_monorepo.yaml Show resolved Hide resolved

kianenigma reviewed May 23, 2023

View reviewed changes

update colors

639ff28

Co-authored-by: Juan <juangirini@gmail.com>

the-right-joyce linked an issue Jun 13, 2023 that may be closed by this pull request

Labels in the monorepo #25

Closed

delete B* labels

b6deabd

juangirini reviewed Jun 15, 2023

View reviewed changes

ruled_labels/[DRAFT]specs_monorepo.yaml Outdated Show resolved Hide resolved

the-right-joyce added 2 commits July 4, 2023 16:21

added contribution labels, deleted B* labels, updated complexity labels

3a49ccd

Merge branch 'the-right-joyce-monorepo-labels' of https://github.com/…

4546eed

…paritytech/labels into the-right-joyce-monorepo-labels

juangirini reviewed Jul 4, 2023

View reviewed changes

ruled_labels/[DRAFT]specs_monorepo.yaml Outdated Show resolved Hide resolved

delete ready for review label

d82d201

kianenigma requested changes Jul 26, 2023

View reviewed changes

the-right-joyce and others added 4 commits July 27, 2023 13:25

add T1 FRAME, T2 Pallets, T11 Cumulus

51cdad6

add version, fix indent

c620537

add test rule

c741d8b

update file name

eb1a3a8

alvicsam merged commit d8d716b into main Aug 25, 2023

alvicsam deleted the the-right-joyce-monorepo-labels branch August 25, 2023 15:27

Conversation

the-right-joyce commented May 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

the-right-joyce May 9, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

juangirini commented May 10, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

koute May 10, 2023

Choose a reason for hiding this comment

Uh oh!

the-right-joyce May 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

koute commented May 10, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michalkucharczyk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

juangirini commented May 15, 2023

Uh oh!

the-right-joyce commented May 19, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kianenigma left a comment

Choose a reason for hiding this comment

Uh oh!

juangirini commented May 23, 2023

Uh oh!

chevdor commented May 30, 2023

Uh oh!

the-right-joyce commented May 30, 2023

Uh oh!

Uh oh!

sam0x17 commented Jun 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bkchr commented Jun 15, 2023

Uh oh!

Uh oh!

kianenigma left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

the-right-joyce commented May 9, 2023 •

edited

Loading

the-right-joyce May 12, 2023 •

edited

Loading

sam0x17 commented Jun 15, 2023 •

edited

Loading