This repository was archived by the owner on Oct 11, 2023. It is now read-only.
On recoverable merge failures, register the PR so that it can continue to be processed later#291
Merged
joao-paulo-parity merged 1 commit intomasterfrom May 26, 2021
Merged
Conversation
joao-paulo-parity
changed the title
joao-paulo-parity
changed the title
more aptly name 'Skipped' as 'MergeFailureWillBeSolvedLater'
joao-paulo-parity
force-pushed
the
merge_failure
branch
from
19d5a00 to
62d908d
Compare
This was referenced May 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shown in paritytech/substrate#8910 (comment)
The MR could not be merged in the first attempt
Then the error was ignored because some status was late
In that case, the PR should have be registered for later processing in the database. In actuality it was not doing anything and just failing silently.