Bump version to 2.2.0 and hide MaxEncodedLen behind an additional crate feature#282
Merged
Bump version to 2.2.0 and hide MaxEncodedLen behind an additional crate feature#282
MaxEncodedLen behind an additional crate feature#282Conversation
coriolinus
approved these changes
Jul 2, 2021
Contributor
coriolinus
left a comment
coriolinus
left a comment
There was a problem hiding this comment.
Some nits, but a good idea to un-stick the process.
Contributor
Author
|
Thanks for taking a look! I'll publish these crates now |
Contributor
|
Any chance to also make changes to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the scheme outlined in paritytech/parity-common#552 (comment).
This avoids the required otherwise cascade bumps across https://github.com/paritytech/parity-common which is something that I didn't consider at first due to the requirement of explicitly selecting pre-releases. Thanks to that, other dependencies can keep on depending on
^2or^2.1versions of the codec, while the only crate outside of the Substrate workspace, which isprimitive-types -> impl-codec, can just opt-in tomax-encoded-lenand directly implement the new trait. Since the trait definition is somewhat stable and FWIU only related new attributes require some more polish, this will probably not cause any breakages.Tested locally paritytech/substrate#9163 and it's looking good so far.