Import some scripts from other repositories#86
Closed
joao-paulo-parity wants to merge 5 commits intoparitytech:masterfrom
Closed
Import some scripts from other repositories#86joao-paulo-parity wants to merge 5 commits intoparitytech:masterfrom
joao-paulo-parity wants to merge 5 commits intoparitytech:masterfrom
Conversation
joao-paulo-parity
requested review from
a team and
alvicsam
and removed request for
alvicsam
mordamax
reviewed
Nov 29, 2022
check-each-crate.sh
Outdated
| @@ -0,0 +1,54 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| ## A script that checks each workspace crate individually. | |||
Contributor
There was a problem hiding this comment.
nit: script which runs "cargo check" per crate in a workspace individually
|
|
||
| set -vx | ||
|
|
||
| target_group="$1" |
Contributor
There was a problem hiding this comment.
could you please describe how the target group look like? so it's a bit more clear how to test this e.g. the context you run it and examples of where you get these groups
| #!/usr/bin/env bash | ||
|
|
||
| ## A script that generates a link to the weights comparison tool, then creates a | ||
| ## PR with the generated link in its description. |
Contributor
There was a problem hiding this comment.
would be cool to add info where is it used (integrated) and why. How people get the link to PR or how is it used overall
mordamax
approved these changes
Dec 12, 2022
Contributor
|
it's outdated a bit, so closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some scripts such as https://github.com/paritytech/substrate/blob/master/scripts/ci/gitlab/check-each-crate.sh and https://github.com/paritytech/cumulus/blob/master/scripts/ci/create-benchmark-pr.sh can useful for many repositories, so it's better to host them here.
I can adapt the Substrate's script usage within Substrate, after this PR is merged, through paritytech/substrate#12768. I don't intend to open a PR for the Cumulus script right now, but a ticket can be created for that.