Update all references in Cargo.lock for patched crates#89
Merged
joao-paulo-parity merged 3 commits intoparitytech:masterfrom Dec 5, 2022
Merged
Update all references in Cargo.lock for patched crates#89joao-paulo-parity merged 3 commits intoparitytech:masterfrom
joao-paulo-parity merged 3 commits intoparitytech:masterfrom
Conversation
mordamax
reviewed
Dec 5, 2022
| sort | | ||
| uniq | ||
| ) | ||
| cargo update "${comp_update_args[@]}" |
Contributor
Author
There was a problem hiding this comment.
No, because cargo check is being executed without the --locked flag below, as intended: Cargo.lock will invariably need to be updated because we're patching packages into projects
Contributor
Author
|
It's working as per https://gitlab.parity.io/parity/mirrors/substrate/builds/2117207 and https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2117249 |
This reverts commit 843b042.
mordamax
approved these changes
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works around https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2115137#L1544
Comparing https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2115137#L1544, which failed to compile
polkadot-node-subsystem-test-helperswith errors such aswith https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2116743#L1811, which got past that point, I think that the fix is effective.
ref paritytech/substrate#12837 (comment)