fatxpool: fix: remove invalid txs from the dropped stream controller
#8923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkucharczyk
added
R0-no-crate-publish-required
Contributor
Author
|
/cmd prdoc --bump minor --audience node_dev |
…-audience node_dev'
skunert
approved these changes
Jun 20, 2025
iulianbarbu
approved these changes
Jun 20, 2025
Member
|
Maybe adding some test to ensure this never happens again? |
Contributor
Author
here you go: a643a28 |
substrate/client/transaction-pool/src/fork_aware_txpool/fork_aware_txpool.rs
Show resolved
Hide resolved
iulianbarbu
approved these changes
Jun 22, 2025
michalkucharczyk
added
the
A4-backport-stable2506
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-8923-to-stable2506
git worktree add --checkout .worktree/backport-8923-to-stable2506 backport-8923-to-stable2506
cd .worktree/backport-8923-to-stable2506
git reset --hard HEAD^
git cherry-pick -x 63973ccc7108560b2d0a7d882e5c0e232d9396ac
git push --force-with-lease |
michalkucharczyk
added
R0-no-crate-publish-required
|
Git push to origin failed for stable2506 with exitcode 1 |
michalkucharczyk
added
A4-backport-stable2506
|
Git push to origin failed for stable2506 with exitcode 1 |
michalkucharczyk
added a commit
that referenced
this pull request
Jun 26, 2025
Backport #8923 into `stable2506` from michalkucharczyk. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing mortal transaction I encountered exactly the same problem as in #8490.
This PR should fix the problem.
fixes: #8490