Deduplicate client-side inherents checking logic #9175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serban300
added
the
I9-optimisation
Contributor
Author
|
/cmd prdoc --audience node_dev --bump patch |
…e_dev --bump patch'
bkchr
approved these changes
Jul 13, 2025
bkchr
added
T0-node
x3c41a
approved these changes
Jul 14, 2025
Merged
via the queue into
paritytech:master
with commit Jul 14, 2025
f8a1fe6
283 of 284 checks passed
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
Stumbled upon this while working on other issue (#7902). I thought I might need to change the `CheckInherentsResult` and this deduplication would have made everything easier. Probably changing `CheckInherentsResult` won't be needed in the end, but even so it would be nice to reduce the duplication. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stumbled upon this while working on other issue (#7902). I thought I might need to change the
CheckInherentsResultand this deduplication would have made everything easier. Probably changingCheckInherentsResultwon't be needed in the end, but even so it would be nice to reduce the duplication.