This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Update to latest substrate-master and polkadot v0.3#195
Merged
Conversation
* update substrate v0.3 to latest master * bump spec version * update to latest master: remove fees module * update runtime blobs * bump version to 0.3.16
* call on_finalise after triggering curated_grandpa change * make grandpa rounds shorter for faster finalization
* update to latest substrate master * bump version to 0.3.18 * update to latest substrate master * bump spec version * update runtime wasm blobs * remove current_offline_slash from chain spec
* update to substrate master: bump version to v0.3.19 libp2p network improvements * network: replace NodeIndex with PeerId * network: fix tests
* update to substrate master: bump version to 0.3.20 * runtime: add offchain worker trait * runtime: rebuild wasm blobs
andresilva
reviewed
Mar 27, 2019
Contributor
andresilva
left a comment
andresilva
left a comment
There was a problem hiding this comment.
overall lgtm. but would like @rphmeier to sign-off on it.
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "polkadot-service" | |||
| version = "0.3.0" | |||
Contributor
There was a problem hiding this comment.
we should probably use a different version for master branch (maybe 0.4?).
network/src/router.rs
Outdated
| } | ||
|
|
||
| /// Receiver for block data. | ||
| pub struct BlockDataReceiver { |
Contributor
There was a problem hiding this comment.
This doesn't seem to be used anymore.
Cargo.toml
Outdated
| [package] | ||
| name = "polkadot" | ||
| version = "0.3.0" | ||
| version = "0.3.20" |
rphmeier
reviewed
Mar 28, 2019
| Staking: staking, | ||
| Democracy: democracy, | ||
| Grandpa: grandpa::{Module, Call, Storage, Config<T>, Log(), Event<T>}, | ||
| CuratedGrandpa: curated_grandpa::{Module, Call, Config<T>, Storage}, |
Contributor
There was a problem hiding this comment.
If we are using curated_grandpa, we should remove grandpa::SyncedAuthorities from OnSessionChange.
rphmeier
suggested changes
Mar 28, 2019
Contributor
rphmeier
left a comment
rphmeier
left a comment
There was a problem hiding this comment.
just the one grumble, otherwise looks OK
rphmeier
approved these changes
Mar 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch combines latest polkadot master, v0.3 and substrate master.