This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Use define_benchmarks!#4760
Merged
paritytech-processbot[bot] merged 2 commits intomasterfrom Jan 21, 2022
Merged
Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
A0-please_review
ggwpez
requested review from
antonio-dropulic,
svyatonik and
tomusdrw
as code owners
shawntabrizi
approved these changes
Jan 21, 2022
kianenigma
approved these changes
Jan 21, 2022
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
The rialto-parachain runtime config somehow has no list_benchmark (nor benchmark_metadata) call, only add.
I think it is fine to just ping someone from the bridge team and let them update to the new syntax if/when they wish.
Member
Author
|
bot merge |
Wizdave97
pushed a commit
to ComposableFi/polkadot
that referenced
this pull request
Feb 3, 2022
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
paritytech/substrate#10592 made it possible to reduce the combination of
add_benchmark+list_benchmarkto just onedefine_benchmarks.This MR refactors the code to use it.
Same as in Cumulus paritytech/cumulus#926
@ reviewers
rialto-parachainruntime config somehow has nolist_benchmark(norbenchmark_metadata) call, onlyadd.cargo run --features=runtime-benchmarks -- benchmark --chain=westend-dev --pallet="*" --extrinsic="*" --listfor the chain specs:westend,rococo,polkadot,kusamabut I could not test it forrialto,rialto-parachainsandmillau.