This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Closed
Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
A0-please_review
ggwpez
commented
Apr 4, 2023
| /// The new validators will be active from current session + 2. | ||
| #[pallet::call_index(0)] | ||
| #[pallet::weight(100_000)] | ||
| #[pallet::weight({100_000})] |
Member
Author
There was a problem hiding this comment.
This will get a deprecation warning in the future anyway when we deprecate the From<u64> for Weight hacks.
s0me0ne-unkn0wn
approved these changes
Apr 4, 2023
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Member
Author
|
Merged into #7006 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warnings were ignored by the companion check after paritytech/substrate#13798 and are causing CI failures.
Changes: