Skip to content

fix: support fee calculation for BifrostPolkadot#1009

Merged
TarikGul merged 1 commit intoparitytech:masterfrom
hqwangningbo:master
Aug 19, 2022
Merged

fix: support fee calculation for BifrostPolkadot#1009
TarikGul merged 1 commit intoparitytech:masterfrom
hqwangningbo:master

Conversation

@hqwangningbo
Copy link
Contributor

No description provided.

@hqwangningbo hqwangningbo requested a review from a team as a code owner August 5, 2022 08:30
@cla-bot-2021
Copy link

cla-bot-2021 bot commented Aug 5, 2022

User @hqwangningbo, please sign the CLA here.

@TarikGul
Copy link
Member

TarikGul commented Aug 5, 2022

Hey @hqwangningbo, Thanks for the contribution. This is my bad as I need to remove the guide for adding fee calculation. But @substrate/calc calcFee is no longer supported in Sidecar. This is because weight_to_fee and length_to_fee is no longer exposed in substrate. We are working to expand the algorithm to support all chains fees by default without anyone having to add their fee config. The following PR #974 and discussion can be seen here.

I will leave this PR up if you still want the config for the controllers in, but if you want accurate partialFee abstraction, for now it is advised to use ?feeByEvent=true query param for /blocks. Let me know if you still want it in.

@hqwangningbo
Copy link
Contributor Author

Hey @TarikGul,thank you for your work. I understand 😊

@TarikGul
Copy link
Member

TarikGul commented Aug 8, 2022

@hqwangningbo, if you revert the changes in calc we can still push this in with the Bifrost controller configs. :)

@hqwangningbo hqwangningbo reopened this Aug 8, 2022
@hqwangningbo
Copy link
Contributor Author

@hqwangningbo, if you revert the changes in calc we can still push this in with the Bifrost controller configs. :)

Hey @TarikGul, I have updated it.

@TarikGul
Copy link
Member

TarikGul commented Aug 9, 2022

LGTM, @hqwangningbo is there an active node for bifrost_polkadot right now to double check the specName?

@hqwangningbo
Copy link
Contributor Author

LGTM, @hqwangningbo is there an active node for bifrost_polkadot right now to double check the specName?

yes , we have😊. wss://hk.p.bifrost-rpc.liebi.com/ws

@hqwangningbo hqwangningbo requested a review from TarikGul August 16, 2022 21:04
@TarikGul TarikGul merged commit 2fdbe31 into paritytech:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants