Conversation
Member
|
Should we really include the |
Contributor
Author
I can take it out, my initial thinking was to keep it as simple as possible to later automate this synchronization with Substrate's |
athei
approved these changes
Sep 1, 2021
Member
athei
left a comment
athei
left a comment
There was a problem hiding this comment.
I can take it out, my initial thinking was to keep it as simple as possible to later automate this synchronization with Substrate's node-template.
I don't care that much. If it makes life easier for you just leave it in. Was just making sure that this isn't an oversight.
HCastano
approved these changes
Sep 1, 2021
Contributor
|
@cmichi We should enable squash merges by default in the repo (I can't since I'm not a repo owner/admin) |
cmichi
added a commit
to shawntabrizi/substrate-contracts-workshop
that referenced
this pull request
Sep 6, 2021
cmichi
added a commit
to use-ink/ink-docs
that referenced
this pull request
Sep 6, 2021
HCastano
pushed a commit
to use-ink/ink-docs
that referenced
this pull request
Sep 6, 2021
cmichi
added a commit
to shawntabrizi/substrate-contracts-workshop
that referenced
this pull request
Sep 7, 2021
* Migrate using `canvas-node` to `substrate-contracts-node` Follow-up to paritytech/substrate-contracts-node#1. * Upgrade to `cargo-contract` `v0.14.0` * Clarify used module * Fix executable name
ShaSear64
added a commit
to ShaSear64/substrate-contracts-workshop
that referenced
this pull request
Sep 20, 2025
* Migrate using `canvas-node` to `substrate-contracts-node` Follow-up to paritytech/substrate-contracts-node#1. * Upgrade to `cargo-contract` `v0.14.0` * Clarify used module * Fix executable name
eth-rangermaz32
added a commit
to eth-rangermaz32/ink-docs
that referenced
this pull request
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most important commit to review is "Modify
node-templateforsubstrate-contracts-node".Preview of the readme can be found here.
As a follow-up I'll adapt our ink! tutorials, workshop and
ink-docsto reference this node instead of thecanvas-node. This is a pre-condition for merging paritytech/canvas#73, as we would break existing tutorials, etc. otherwise.We subsequently also need to adapt
ink-waterfallto use this node for testing. This can only be done after we have GitLab set-up for this repo though. I've created https://github.com/paritytech/ci_cd/issues/189 forthis. After that is done we can add the
.gitlab-ci.ymlfromcanvas-node.