chore(license): apply proper licensing and giving polkadot-js copyright credit#69
Merged
chore(license): apply proper licensing and giving polkadot-js copyright credit#69
Conversation
jsdw
reviewed
May 20, 2022
jsdw
approved these changes
May 20, 2022
niklasad1
reviewed
May 21, 2022
| @@ -1,4 +1,12 @@ | |||
| #!/usr/bin/env node | |||
There was a problem hiding this comment.
The license should go in before #!/usr/bin/env node or is that not possible?
Same for the rest too
Member
Author
There was a problem hiding this comment.
Yea its not possible unfortunately :(
Member
Author
There was a problem hiding this comment.
Which I thought was pretty odd because I tried to do the same thing, but it didn't work.
There was a problem hiding this comment.
yeah it's probably a UNIX thingy.
I guess # comments would work I did comments like that when I used python back in the days when I was a beginner...
niklasad1
approved these changes
May 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This puts the license at the top of each file, but also gives polkadot-js the proper credit for code that was adopted from
@polkadot/dev.