This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
try-runtime-cli: support testing new multi-block migrations #14291
Copy link
Copy link
Closed
Labels
J0-enhancementAn additional feature request.An additional feature request.S4-blockedIssue is blocked, see comments for further information.Issue is blocked, see comments for further information.T1-runtimeThis PR/Issue is related to the topic “runtime”.This PR/Issue is related to the topic “runtime”.Z2-mediumCan be fixed by a coder with good Rust knowledge but little knowledge of the codebase.Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.
Description
@kianenigma am I right to assume we'll want to make it easy to test these with try-runtime-cli? Ideally should be as easy as `on-runtime-upgrade`, maybe make it auto-mine blocks until all multi-block migrations are complete & provide a hook that runs afterwards?
Originally posted by @liamaharon in #14275 (comment)
Kian response:
Good to think about it early, and yes I think it is possible with little effort. I believe follow-chain will already do everything needed to test an MBM?
I don't think follow-chain is necessarily a good solution.
- We need to call each upgrade's
post_upgradehook once its migration has finished executing. - We can't use snapshots with
follow-chain, making development iterations much slower and requiring a live node running. Some of the plumbing infast-forwardis might be a better solution here?
Ideally, I think we'd be able to run on-runtime-upgrade like usual and it'll fast-forward until all migrations have completed, and then run a post_migration hook. Unfortunately fast-forward is not production ready due to the inherents issue, it seems this feature makes fixing the inherents issue much higher priority now?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
J0-enhancementAn additional feature request.An additional feature request.S4-blockedIssue is blocked, see comments for further information.Issue is blocked, see comments for further information.T1-runtimeThis PR/Issue is related to the topic “runtime”.This PR/Issue is related to the topic “runtime”.Z2-mediumCan be fixed by a coder with good Rust knowledge but little knowledge of the codebase.Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.
Type
Projects
Status
Done