Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Change genesis.code encoding in chainspec to bytes. #4454

@tomusdrw

Description

@tomusdrw

Currently genesis.code inside chain spec JSON is encoded as raw Vec<u8> which results in a JSON array containing shitload of numbers, which by default when pretty-printed results in one number per line.

Instead we should encode code as hex (see Bytes wrapper) as it's way more compact, but to maintain backward compatibility we should support both formats when deserializing the chain spec.

CC @JoshOrndorff, I saw that on your seminar and thought that we could fix it :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    I4-annoyanceThe client behaves within expectations, however this “expected behaviour” itself is at issue.Z1-easyCan be fixed primarily by duplicating and adapting code by an intermediate coderZ6-mentorAn easy task where a mentor is available. Please indicate in the issue who the mentor could be.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions