Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

--wasm-runtime-overrides does not check spec name #9685

@JoshOrndorff

Description

@JoshOrndorff
        --wasm-runtime-overrides <PATH>                          
            Specify the path where local WASM runtimes are stored.
            
            These runtimes will override on-chain runtimes when the version matches.

As the docs say, the runtime version is checked. But it seems the spec name is not checked. On an internal testnet, we recently (accidentally) used a moon_river_ runtime as an override when we should have used a moon_beam_ runtime. As expected, that led to a lot of unintended consequences.

It would be helpful if the spec name was checked and either:

  1. Refuse to use overrides for different runtimes
  2. Print a warning at node startup

Metadata

Metadata

Assignees

No one assigned

    Labels

    J0-enhancementAn additional feature request.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions