Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Upgrade sc-chain-spec to Rust 2021#10092

Closed
KiChjang wants to merge 1 commit intomasterfrom
kckyeung/chain-spec-2021
Closed

Upgrade sc-chain-spec to Rust 2021#10092
KiChjang wants to merge 1 commit intomasterfrom
kckyeung/chain-spec-2021

Conversation

@KiChjang
Copy link
Contributor

@KiChjang KiChjang commented Oct 23, 2021

Partial fix for #10084.

@KiChjang KiChjang added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Oct 23, 2021
@KiChjang KiChjang requested a review from tomusdrw October 23, 2021 17:07
@KiChjang
Copy link
Contributor Author

KiChjang commented Oct 23, 2021

Ah crud, none of our CI machines are upgraded to Rust 1.56 yet...

@bkchr
Copy link
Member

bkchr commented Oct 23, 2021

@KiChjang if you want to do this, could you upgrade all crates?

@nuke-web3
Copy link
Contributor

nuke-web3 commented Oct 23, 2021 •
edited
Loading

Ah crud, none of our CI machines are upgraded to Rust 1.56 yet...

@chevdor might have opinions about this

@bkchr
Copy link
Member

bkchr commented Oct 23, 2021

@nukemandan the CI image just needs to be updated.

@nuke-web3
Copy link
Contributor

nuke-web3 commented Oct 23, 2021 •
edited
Loading

I know this was mentioned as a possible issue, see polkadot-developers/substrate-docs#407 based on an element chat with Chevdor

@gilescope
Copy link
Contributor

gilescope commented Nov 3, 2021

CI updated, just needs merge master

@chevdor
Copy link
Contributor

chevdor commented Nov 3, 2021

I am currently testing the latest srtool (1.56.1) against the node-template in both master and kckyeung/chain-spec-2021.

@chevdor
Copy link
Contributor

chevdor commented Nov 3, 2021

I am currently testing the latest srtool (1.56.1) against the node-template in both master and kckyeung/chain-spec-2021.

It is a ✅ on my end for both branches in the current state.

@bkchr
Copy link
Member

bkchr commented Nov 3, 2021

Superseded by: #10170

@bkchr bkchr closed this Nov 3, 2021
@bkchr bkchr deleted the kckyeung/chain-spec-2021 branch November 3, 2021 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tomusdrw tomusdrw Awaiting requested review from tomusdrw

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@KiChjang @bkchr @nuke-web3 @gilescope @chevdor