This repository was archived by the owner on Nov 15, 2023. It is now read-only.
rework staking::reap_stash#10178
Merged
paritytech-processbot[bot] merged 6 commits intomasterfrom Nov 14, 2021
Merged
Conversation
kianenigma
added
A0-please_review
Contributor
Author
const ED = new BN(10000000000);
const ledgers = await api.query.staking.ledger.entries();
let count = 0;
let stale = 0;
for (let [ctrl, ledger] of ledgers) {
const total = ledger.unwrapOrDefault().total;
count += 1;
if (total.toBn().lte(ED)) {
stale += 1;
console.log(`🚨 ${ctrl.args[0].toHuman()} has ledger ${api.createType('Balance', total).toHuman()}.`)
}
}
console.log(`${stale} / ${count} are stale`);unravels that there are |
emostov
reviewed
Nov 10, 2021
emostov
approved these changes
Nov 10, 2021
Contributor
emostov
left a comment
emostov
left a comment
There was a problem hiding this comment.
Overall looks good, just a few comments
Co-authored-by: Zeke Mostov <z.mostov@gmail.com>
Co-authored-by: Zeke Mostov <z.mostov@gmail.com>
Co-authored-by: Zeke Mostov <z.mostov@gmail.com>
shawntabrizi
approved these changes
Nov 10, 2021
kianenigma
added
B7-runtimenoteworthy
and removed
B0-silent
Contributor
Author
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Checks failed for 459359e |
Contributor
Author
|
bot merge |
23 tasks
viniul
added
D1-audited 👍
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* rework reap_stash * Update frame/staking/src/pallet/mod.rs Co-authored-by: Zeke Mostov <z.mostov@gmail.com> * Update frame/staking/src/pallet/mod.rs Co-authored-by: Zeke Mostov <z.mostov@gmail.com> * Update frame/staking/src/pallet/mod.rs Co-authored-by: Zeke Mostov <z.mostov@gmail.com> * Fix Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Zeke Mostov <z.mostov@gmail.com>
aurexav
added a commit
to darwinia-network/darwinia-common
that referenced
this pull request
Aug 4, 2022
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* rework reap_stash * Update frame/staking/src/pallet/mod.rs Co-authored-by: Zeke Mostov <z.mostov@gmail.com> * Update frame/staking/src/pallet/mod.rs Co-authored-by: Zeke Mostov <z.mostov@gmail.com> * Update frame/staking/src/pallet/mod.rs Co-authored-by: Zeke Mostov <z.mostov@gmail.com> * Fix Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Zeke Mostov <z.mostov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes reap-stash to be able to also reap an account that due to any reason have a
ledger.activeless than existential deposit. Also makes the transaction signed, but free in case of successful execution, for better protection.