This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Offence implementations can disable offenders independently from slashing#10201
Merged
paritytech-processbot[bot] merged 10 commits intomasterfrom Nov 17, 2021
Merged
Offence implementations can disable offenders independently from slashing#10201paritytech-processbot[bot] merged 10 commits intomasterfrom
paritytech-processbot[bot] merged 10 commits intomasterfrom
Conversation
wigy-opensource-developer
added
A0-please_review
added 2 commits
November 5, 2021 17:36
bkchr
reviewed
Nov 5, 2021
kianenigma
reviewed
Nov 8, 2021
kianenigma
reviewed
Nov 8, 2021
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
LGTM; @ordian does this address your issue?
wigy-opensource-developer
added
D3-trivial 🧸
bkchr
approved these changes
Nov 8, 2021
bkchr
suggested changes
Nov 8, 2021
andresilva
suggested changes
Nov 8, 2021
Contributor
andresilva
left a comment
andresilva
left a comment
There was a problem hiding this comment.
lgtm. just minor nits.
bkchr
approved these changes
Nov 9, 2021
wigy-opensource-developer
force-pushed
the
wigy-offence-disable
branch
from
7fc4718 to
cd353c8
Compare
andresilva
approved these changes
Nov 17, 2021
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Checks failed for cd353c8 |
|
bot merge |
|
Waiting for commit status. |
23 tasks
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
…hing (paritytech#10201) * Offence implementations can disable offenders independently from slashing * Fix build on CI * Run cargo fmt * Fixes based on review comments * Make parameter naming consistent * Fix migration and some English * Fix migration - again * cargo fmt * Cover 2 new cases with a test
aurexav
added a commit
to darwinia-network/darwinia-common
that referenced
this pull request
Aug 4, 2022
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…hing (paritytech#10201) * Offence implementations can disable offenders independently from slashing * Fix build on CI * Run cargo fmt * Fixes based on review comments * Make parameter naming consistent * Fix migration and some English * Fix migration - again * cargo fmt * Cover 2 new cases with a test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In previous versions any slashed offenders got disabled by every offence. Now pallet developers can decide for each
Offenceimplementation whether to disable them regardless of the slashed amount. Some use-cases would benefit from disabling offenders without slashing, so now they can overrideOffence::disable_strategy.Fixes #10037
TODO:
skip check-dependent-cumulus