Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Remove invalid link without fixing them#10344

Merged
paritytech-processbot[bot] merged 1 commit intomasterfrom
gui-ignore-error
Nov 29, 2021
Merged

Remove invalid link without fixing them#10344
paritytech-processbot[bot] merged 1 commit intomasterfrom
gui-ignore-error

Conversation

@gui1117
Copy link
Contributor

@gui1117 gui1117 commented Nov 23, 2021

here are the doc which must be fixed: (some seems to link to removed items, some are linking to private items, and some others link to unreachable items) once this PR is merged I'll open an issue with the following items so we can track them and fix them later.

This PR also fix some other.

With this PR in we should be able to add the flag RUSTDOCFLAGS="-Dwarnings" in the CI and have the job build-rustdoc mandatory. cc @TriplEight

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Nov 23, 2021
@gui1117 gui1117 added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Nov 23, 2021
@gui1117
Copy link
Contributor Author

gui1117 commented Nov 29, 2021

bot merge

@paritytech-processbot paritytech-processbot bot merged commit f2cecdb into master Nov 29, 2021
@paritytech-processbot paritytech-processbot bot deleted the gui-ignore-error branch November 29, 2021 08:16
@gui1117
Copy link
Contributor Author

gui1117 commented Nov 29, 2021

issue opened here #10385

niklasad1 added a commit that referenced this pull request Dec 2, 2021
chevdor pushed a commit that referenced this pull request Jan 11, 2022
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants