This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Remove invalid link without fixing them#10344
Merged
paritytech-processbot[bot] merged 1 commit intomasterfrom Nov 29, 2021
Merged
Remove invalid link without fixing them#10344paritytech-processbot[bot] merged 1 commit intomasterfrom
paritytech-processbot[bot] merged 1 commit intomasterfrom
Conversation
bkchr
approved these changes
Nov 23, 2021
kianenigma
approved these changes
Nov 26, 2021
Contributor
Author
|
bot merge |
Contributor
Author
|
issue opened here #10385 |
chevdor
pushed a commit
that referenced
this pull request
Jan 11, 2022
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
here are the doc which must be fixed: (some seems to link to removed items, some are linking to private items, and some others link to unreachable items) once this PR is merged I'll open an issue with the following items so we can track them and fix them later.
substrate/client/network/src/block_request_handler.rs
Line 18 in 4de8ee2
substrate/client/network/src/light_client_requests/handler.rs
Line 22 in 4de8ee2
substrate/client/network/src/service.rs
Line 713 in 4de8ee2
substrate/client/network/src/service.rs
Line 778 in 4de8ee2
substrate/client/network/src/state_request_handler.rs
Line 18 in 4de8ee2
substrate/client/service/src/client/mod.rs
Lines 40 to 42 in 4de8ee2
substrate/utils/frame/try-runtime/cli/src/lib.rs
Line 128 in 4de8ee2
substrate/utils/frame/try-runtime/cli/src/lib.rs
Line 144 in 4de8ee2
substrate/utils/frame/try-runtime/cli/src/lib.rs
Line 154 in 4de8ee2
substrate/utils/frame/try-runtime/cli/src/lib.rs
Line 245 in 4de8ee2
substrate/utils/frame/try-runtime/cli/src/lib.rs
Line 317 in 4de8ee2
substrate/utils/frame/try-runtime/cli/src/lib.rs
Line 329 in 4de8ee2
substrate/utils/frame/try-runtime/cli/src/lib.rs
Line 338 in 4de8ee2
substrate/utils/frame/try-runtime/cli/src/lib.rs
Line 350 in 4de8ee2
This PR also fix some other.
With this PR in we should be able to add the flag
RUSTDOCFLAGS="-Dwarnings"in the CI and have the jobbuild-rustdocmandatory. cc @TriplEight